Skip to content

Commit 42dda58

Browse files
author
Bryant Howell
authored
Merge pull request #105 from bryantbhowell/5.2.1
5.2.1 - fixes error in permissions settings code
2 parents 1cb0b69 + 5b724e5 commit 42dda58

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+6
-6
lines changed

.gitattributes

100644100755
File mode changed.

.gitignore

100644100755
File mode changed.

.idea/vcs.xml

100644100755
File mode changed.

License.txt

100644100755
File mode changed.

README.md

100644100755
File mode changed.

__init__.py

100644100755
File mode changed.

examples/archive_site.py

100644100755
File mode changed.

examples/create_site_sample.py

100644100755
File mode changed.

examples/hyper_api_samples.py

100644100755
File mode changed.

examples/limited_rest_api_wrapping_tableau_rest_api.py

100644100755
File mode changed.

examples/modifying_users_immediately_before_sso.py

100644100755
File mode changed.

examples/move_extracts_from_server_to_server.py

100644100755
File mode changed.

examples/permissions_auditing.py

100644100755
File mode changed.

examples/replicate_site_structure_sample.py

100644100755
File mode changed.

examples/template_publish_sample.py

100644100755
File mode changed.

examples/test_suite_all_add_update_delete_publish_tableau_server_rest.py

100644100755
File mode changed.

examples/test_suite_all_querying_tableau_rest_api_connection.py

100644100755
File mode changed.

examples/test_suite_all_querying_tableau_server_rest.py

100644100755
File mode changed.

examples/test_suite_tableau_documents.py

100644100755
File mode changed.

examples/user_sync_sample.py

100644100755
File mode changed.

logger.py

100644100755
File mode changed.

logging_methods.py

100644100755
File mode changed.

requirements.txt

100644100755
File mode changed.

rest_tokens_manager.py

100644100755
File mode changed.

setup.py

100644100755
+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
setup(
44
name='tableau_tools',
55
python_requires='>=3.6',
6-
version='5.2.0',
6+
version='5.2.1',
77
packages=['tableau_tools', 'tableau_tools.tableau_rest_api', 'tableau_tools.tableau_documents',
88
'tableau_tools.examples', 'tableau_tools.tableau_rest_api.methods'],
99
url='https://github.com/bryantbhowell/tableau_tools',

tabcmd.py

100644100755
File mode changed.

tableau_documents/__init__.py

100644100755
File mode changed.

tableau_documents/hyper_file_generator.py

100644100755
File mode changed.

tableau_documents/table_relations.py

100644100755
File mode changed.

tableau_documents/tableau_columns.py

100644100755
File mode changed.

tableau_documents/tableau_connection.py

100644100755
File mode changed.

tableau_documents/tableau_datasource.py

100644100755
File mode changed.

tableau_documents/tableau_document.py

100644100755
File mode changed.

tableau_documents/tableau_file.py

100644100755
File mode changed.

tableau_documents/tableau_parameters.py

100644100755
File mode changed.

tableau_documents/tableau_workbook.py

100644100755
File mode changed.

tableau_emailer.py

100644100755
File mode changed.

tableau_exceptions.py

100644100755
File mode changed.

tableau_http.py

100644100755
File mode changed.

tableau_repository.py

100644100755
File mode changed.

tableau_rest_api/__init__.py

100644100755
File mode changed.

tableau_rest_api/methods/__init__.py

100644100755
File mode changed.

tableau_rest_api/methods/_lookups.py

100644100755
File mode changed.

tableau_rest_api/methods/alert.py

100644100755
File mode changed.

tableau_rest_api/methods/datasource.py

100644100755
File mode changed.

tableau_rest_api/methods/extract.py

100644100755
File mode changed.

tableau_rest_api/methods/favorites.py

100644100755
File mode changed.

tableau_rest_api/methods/flow.py

100644100755
File mode changed.

tableau_rest_api/methods/group.py

100644100755
File mode changed.

tableau_rest_api/methods/metadata.py

100644100755
File mode changed.

tableau_rest_api/methods/project.py

100644100755
File mode changed.

tableau_rest_api/methods/rest_api_base.py

100644100755
File mode changed.

tableau_rest_api/methods/revision.py

100644100755
File mode changed.

tableau_rest_api/methods/schedule.py

100644100755
File mode changed.

tableau_rest_api/methods/site.py

100644100755
File mode changed.

tableau_rest_api/methods/subscription.py

100644100755
File mode changed.

tableau_rest_api/methods/user.py

100644100755
File mode changed.

tableau_rest_api/methods/webhooks.py

100644100755
File mode changed.

tableau_rest_api/methods/workbook.py

100644100755
File mode changed.

tableau_rest_api/permissions.py

100644100755
File mode changed.

tableau_rest_api/published_content.py

100644100755
+5-5
Original file line numberDiff line numberDiff line change
@@ -456,17 +456,17 @@ def set_permissions_by_permissions_obj_list(self, new_permissions_obj_list):
456456
# Check if there are any existing capabilities on the object
457457
if cur_obj.luid == new_permissions_obj.luid:
458458
# Find if anything is set already, add to deletion queue
459-
need_to_change = self.are_capabilities_obj_dicts_identical(
459+
are_identical = self.are_capabilities_obj_dicts_identical(
460460
cur_obj.get_capabilities_dict(), new_permissions_obj.get_capabilities_dict()
461461
)
462-
self.log("Existing permissions found for luid {}. Are there differences? {}".format(cur_obj.luid,
463-
str(need_to_change)))
462+
self.log("Existing permissions found for luid {}. Are they the same? {}".format(cur_obj.luid,
463+
str(are_identical)))
464464
# Delete all existing permissions
465-
if need_to_change is True:
465+
if are_identical is False:
466466
self.log("Removing existing permissions for luid {}".format(cur_obj.luid))
467467
self.delete_permissions_by_permissions_obj_list([cur_obj, ])
468468

469-
if need_to_change is False:
469+
if are_identical is True:
470470
self.log('No changes necessary, skipping update for quicker performance')
471471
# self.end_log_block()
472472
continue

tableau_rest_api/rest_json_request.py

100644100755
File mode changed.

tableau_rest_api/rest_xml_request.py

100644100755
File mode changed.

tableau_rest_api/sort.py

100644100755
File mode changed.

tableau_rest_api/url_filter.py

100644100755
File mode changed.

tableau_rest_api_connection.py

100644100755
File mode changed.

tableau_rest_xml.py

100644100755
File mode changed.

tableau_server_rest.py

100644100755
File mode changed.

0 commit comments

Comments
 (0)