-
Notifications
You must be signed in to change notification settings - Fork 2
Description
ContentType, Title and Uuid sub-elements
Elements of the following types:
- FiberOpticalPath
- DasInstrumentBox
- EpcExternalPartReference
Have the following attributes in the example:
- ContentType
- Title
- Uuid
And I cannot see any information regarding these attributes of the above-listed types or their parents in documentation and schema files. At the same time the UUID is certainly needed to identify to which item they do refer.
Update: It seems that EpcExternalPartReference type in xsd and documentation needs to be split in two different types. It is used as both top-level element for EpcExternalPartReference files in EPC, and also as sub-element for ExternalFileProxy in DasAcquisition xml's. It is currently inherited from the AbstractObject -- that is correct for the top-level element, that is why it has Citation for example. In case when EpcExternalPartReference is used as a sub-element it lacks Uuid, MimeType and Title elements, which present in DataObjectReference and therefore it seems that EpcExternalPartReference should be inherited from DataObjectReference. But in XML schema it is not possible to inherit from two types, only from one. So probably there should be one type of EpcExternalPartReference for the top-level element, and another type of EpcExternalPartReference for the child element. If the types need to have the same name, a possible solution could be to define a separate schema for the top-level element.
or
In ExternalDatasetPart EpcExternalPartReference should be of type DataObjectReference. That seems most probable.
DasInstrumentBox.xsd
xsi:schemaLocation="http://www.energistics.org/energyml/data/prodmlv2 ../../../../xsd_schemas/DasInstrumentBox.xsd" namespace def in the DasInstrumentBox.xml example leads to a thought that there exists the DasInstrumentBox.xsd schema, but it does not exists.
FacilityIdentifierStruct content
In DasInstrumentBox.xml example, line 41:
prodml:ContextFacilitytext</prodml:ContextFacility> -- that should be of FacilityIdentifierStruct type, but the type defines only 4 attributes, not the text between tags. Or freestyle test is supposed to be part of this? (generateDS does not output anything between tags for that class, but that may be generateDS issue as well).
.h5 extension for HDF5 files
All hdf files should have .h5 extension according to the EPC specification, but in examples they have .hdf extension.
_rels/.rels in EPC package
EPC file should contain _rels/.rels file in it with at least one relationship (to the core properties) according to the specification, but it is absent in the examples.
'Target' attribute in relationships
'Target' attribute in coreProps/_rels/core.xml.rels in the examples was neither relative path neither absolute URI which is wrong, accrding to the OPC specification.
Relationship from package or core properties to the data xml files
None of the data xml files (like Aquisition) are referenced from .rels files in the examples. Should they (I guess so)? And if yes, which type of relationship should they have?
core.xml is not filled with metadata in the examples
core.xml should have at least three mandatory fields (version, creator, created), and creator was not in the example.