Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for indirect containment is incorrect #325

Open
Moult opened this issue Jun 20, 2024 · 0 comments
Open

Test case for indirect containment is incorrect #325

Moult opened this issue Jun 20, 2024 · 0 comments
Labels
please contribute A PR is welcome for this issue. Please target the `development` branch. tests
Milestone

Comments

@Moult
Copy link
Contributor

Moult commented Jun 20, 2024

https://github.com/buildingSMART/IDS/blob/development/Documentation/testcases/partof/pass-the_containment_can_be_indirect_1_2.ifc

The beam should be contained in the space, not aggregated.

Also, there should be two interpretations of 'indirect' containment.

  1. Interpretation 1: PASS - a beam in a space: Beam <-- RelAgg --> ElementAssembly <-- RelContain --> Space
  2. Interpretation 2: PASS (or FAIL?) - a beam in a building: Beam <-- RelContain --> Space <-- RelAgg --> Building
@atomczak atomczak added please contribute A PR is welcome for this issue. Please target the `development` branch. and removed todo labels Nov 6, 2024
@atomczak atomczak added this to the 1.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please contribute A PR is welcome for this issue. Please target the `development` branch. tests
Projects
None yet
Development

No branches or pull requests

2 participants