Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should application be detected from header or IfcApplication, and what's the correct header syntax for MVD? #3

Open
Moult opened this issue Oct 30, 2022 · 1 comment
Open

Should application be detected from header or IfcApplication, and what's the correct header syntax for MVD? #3

Moult opened this issue Oct 30, 2022 · 1 comment

Comments

@Moult
Copy link
Collaborator

Moult commented Oct 30, 2022

See IfcOpenShell/IfcOpenShell#2526
@aothms
Copy link
Collaborator

aothms commented Oct 31, 2022

According to the docs referenced by @Moult in the issue above there are a couple issues with:

https://github.com/buildingSMART/validate/blob/release/application/checks/info.py#L22

  • We should use the grammar on p4 not just arbitrarily split on whitespace
  • Should not only read description[0] but all of description

And in general

  • We should report on invalid ifc-header syntax
  • We should check header attribute value types in general in validate.py
  • We should check some of the header values for correctness such as implementation level and the time stamp

Thanks @Moult

CC @evandroAlfieri

@Moult Moult mentioned this issue Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Moult @aothms