Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 11-revoke-roles.js, it incorrectly revokes minting role for Governance/Vote contract #19

Open
Hampton-Black opened this issue Nov 13, 2022 · 0 comments

Comments

@Hampton-Black
Copy link

I believe the recommended code in tutorial for 11-revoke-roles.js incorrectly revokes all minting roles, including the vote/governance contract.

Specifically, in this line:
await token.roles.setAll({ admin: [], minter: [] });

On my local end, I noticed both my personal wallet and the vote contract held minting roles in the 'before' section, and then all were revoked in the 'after' section.

Recommended fix would be to just specify the role to revoke. i.e.:

await token.roles.revoke("admin", process.env.WALLET_ADDRESS);
await token.roles.revoke("minter", process.env.WALLET_ADDRESS);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant