Avoid types juggling

bwplotka · Jul 3, 2024 · e89ae35 · e89ae35
1 parent 56538e3
commit e89ae35
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -39,6 +39,7 @@ linters:
     - gosimple
     - govet
     - ineffassign
+    # - mirror  # requires golangci-lint 1.53
     - misspell
     - staticcheck
     - structcheck

diff --git a/pkg/mdformatter/mdformatter.go b/pkg/mdformatter/mdformatter.go
@@ -182,13 +182,13 @@ func FormatFrontMatter(m map[string]interface{}) ([]byte, error) {
 		keys: keys,
 	}
 
-	b := bytes.NewBuffer([]byte("---\n"))
+	b := bytes.NewBufferString("---\n")
 	o, err := yaml.Marshal(f)
 	if err != nil {
 		return nil, fmt.Errorf("marshall front matter: %w", err)
 	}
 	_, _ = b.Write(o)
-	_, _ = b.Write([]byte("---\n\n"))
+	_, _ = b.WriteString("---\n\n")
 	return b.Bytes(), nil
 }
 

diff --git a/scripts/copyright/copyright.go b/scripts/copyright/copyright.go
@@ -46,7 +46,7 @@ func applyLicenseToProtoAndGo() error {
 			return err
 		}
 
-		if !strings.HasPrefix(string(b), string(license)) {
+		if !bytes.HasPrefix(b, license) {
 			log.Println("file", path, "is missing Copyright header. Adding.")
 
 			var bb bytes.Buffer