Skip to content

Commit 418645b

Browse files
committed
Fix missing RandomAccessFile::is_mmap_open() override
Fix TerarkZipTableReader FileDescriptor issue
1 parent e3b5990 commit 418645b

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

env/io_posix.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ class PosixMmapReadableFile : public RandomAccessFile {
168168
size_t length, const EnvOptions& options);
169169
~PosixMmapReadableFile();
170170
bool use_aio_reads() const final { return use_aio_reads_; }
171+
bool is_mmap_open() const final { return true; }
171172
Status Read(uint64_t offset, size_t n, Slice* result,
172173
char* scratch) const final;
173174
Status InvalidateCache(size_t offset, size_t length) final;

port/win/io_win.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ class WinMmapReadableFile : private WinFileData, public RandomAccessFile {
132132

133133
~WinMmapReadableFile();
134134

135+
bool is_mmap_open() const final { return true; }
136+
135137
WinMmapReadableFile(const WinMmapReadableFile&) = delete;
136138
WinMmapReadableFile& operator=(const WinMmapReadableFile&) = delete;
137139

table/terark_zip_table_reader.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1159,7 +1159,7 @@ Status TerarkZipTableReader::Open(RandomAccessFileReader* file,
11591159
(byte_t*)file_data.data() + indexSize + storeSize, recNum);
11601160
}
11611161
subReader_.subIndex_ = 0;
1162-
// subReader_.storeFD_ = file_->file()->FileDescriptor();
1162+
subReader_.storeFD_ = file_->file()->FileDescriptor();
11631163
subReader_.storeFileObj_ = file_->file();
11641164
subReader_.storeOffset_ = indexSize;
11651165
subReader_.InitUsePread(tzto_.minPreadLen);

0 commit comments

Comments
 (0)