Skip to content

Commit 1fa035a

Browse files
agautam478agautam478
authored
Merge pull request #85 from uber/nondbranch
Added more continue as new cases for Non-Determinism java checks
2 parents 1a2c896 + 35656e9 commit 1fa035a

File tree

3 files changed

+187
-3
lines changed

3 files changed

+187
-3
lines changed

‎src/test/java/com/uber/cadence/samples/replaytests/HelloPeriodicReplayTest.java

+12-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,19 @@ public void testReplay_continueAsNew_moreFrequency() throws Exception {
4141

4242
// Continue as new case: If frequency is changed to lesser number.
4343
// FAIL As expected: It should hit non-determinism case and it is hitting properly.
44+
// @Test
45+
// public void testReplay_continueAsNew_lessFrequency() throws Exception {
46+
// WorkflowReplayer.replayWorkflowExecutionFromResource(
47+
// "replaytests/HelloPeriodic.json",
48+
// HelloPeriodic_lessFrequency.GreetingWorkflowImpl.class);
49+
// }
50+
51+
// Continue as new case: when continue as new has child workflow as well
52+
//EXPECTED: FAIL ACTUAL: FAIL
4453
// @Test
45-
// public void testReplay_continueAsNew_lessFrequency() throws Exception {
54+
// public void testReplay_continueAsNew_withChildWorkflows() throws Exception {
4655
// WorkflowReplayer.replayWorkflowExecutionFromResource(
47-
// "replaytests/HelloPeriodic.json", HelloPeriodic_lessFrequency.GreetingWorkflowImpl.class);
56+
// "replaytests/HelloPeriodic.json",
57+
// HelloPeriodic_withChildWorkflows.GreetingWorkflowImpl.class);
4858
// }
4959
}

‎src/test/java/com/uber/cadence/samples/replaytests/HelloPeriodic_moreFrequency.java

+11-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public interface GreetingActivities {
6464
public static class GreetingWorkflowImpl implements GreetingWorkflow {
6565

6666
// If we change the value to 1, then non-determinism case will hit.
67-
private final int CONTINUE_AS_NEW_FREQUENCEY = 1000;
67+
private final int CONTINUE_AS_NEW_FREQUENCEY = 100000000;
6868

6969
private final GreetingActivities activities =
7070
Workflow.newActivityStub(
@@ -94,9 +94,19 @@ public void greetPeriodically(String name, Duration delay) {
9494
}
9595

9696
static class GreetingActivitiesImpl implements GreetingActivities {
97+
98+
// private int callCount = 1000;
99+
97100
@Override
98101
public void greet(String greeting) {
102+
// callCount++;
99103
System.out.println("From " + Activity.getWorkflowExecution() + ": " + greeting);
104+
105+
// Did not get Non-Determinism for this:
106+
// EXPECTED: YES ACTUAL: NO
107+
// if (callCount > 100) {
108+
// throw new RuntimeException("Exceeded maximum call frequency");
109+
// }
100110
}
101111
}
102112

‎src/test/java/com/uber/cadence/samples/replaytests/HelloPeriodic_withChildWorkflows.java

+164
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,164 @@
1+
/*
2+
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
3+
*
4+
* Modifications copyright (C) 2017 Uber Technologies, Inc.
5+
*
6+
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
7+
* use this file except in compliance with the License. A copy of the License is
8+
* located at
9+
*
10+
* http://aws.amazon.com/apache2.0
11+
*
12+
* or in the "license" file accompanying this file. This file is distributed on
13+
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
14+
* express or implied. See the License for the specific language governing
15+
* permissions and limitations under the License.
16+
*/
17+
18+
package com.uber.cadence.samples.replaytests;
19+
20+
import static com.uber.cadence.samples.common.SampleConstants.DOMAIN;
21+
22+
import com.google.common.base.Throwables;
23+
import com.uber.cadence.WorkflowExecution;
24+
import com.uber.cadence.WorkflowIdReusePolicy;
25+
import com.uber.cadence.activity.Activity;
26+
import com.uber.cadence.activity.ActivityOptions;
27+
import com.uber.cadence.client.DuplicateWorkflowException;
28+
import com.uber.cadence.client.WorkflowClient;
29+
import com.uber.cadence.client.WorkflowClientOptions;
30+
import com.uber.cadence.client.WorkflowException;
31+
import com.uber.cadence.client.WorkflowStub;
32+
import com.uber.cadence.internal.compatibility.Thrift2ProtoAdapter;
33+
import com.uber.cadence.internal.compatibility.proto.serviceclient.IGrpcServiceStubs;
34+
import com.uber.cadence.samples.hello.HelloChild;
35+
import com.uber.cadence.worker.Worker;
36+
import com.uber.cadence.worker.WorkerFactory;
37+
import com.uber.cadence.workflow.Async;
38+
import com.uber.cadence.workflow.Promise;
39+
import com.uber.cadence.workflow.Workflow;
40+
import com.uber.cadence.workflow.WorkflowMethod;
41+
import java.time.Duration;
42+
import java.util.Optional;
43+
44+
public class HelloPeriodic_withChildWorkflows {
45+
46+
static final String TASK_LIST = "HelloPeriodic_withChildWorkflow";
47+
static final String PERIODIC_WORKFLOW_ID = "HelloPeriodic_withChildWorkflow";
48+
49+
public interface GreetingWorkflow {
50+
@WorkflowMethod(
51+
// At most one instance.
52+
workflowId = PERIODIC_WORKFLOW_ID,
53+
// To allow starting workflow with the same ID after the previous one has terminated.
54+
workflowIdReusePolicy = WorkflowIdReusePolicy.AllowDuplicate,
55+
// Adjust this value to the maximum time workflow is expected to run.
56+
// It usually depends on the number of repetitions and interval between them.
57+
executionStartToCloseTimeoutSeconds = 300,
58+
taskList = TASK_LIST
59+
)
60+
void greetPeriodically(String name, Duration delay);
61+
}
62+
63+
public interface GreetingActivities {
64+
void greet(String greeting);
65+
}
66+
67+
public static class GreetingWorkflowImpl implements GreetingWorkflow {
68+
69+
private final int CONTINUE_AS_NEW_FREQUENCEY = 1000;
70+
71+
private final GreetingActivities activities =
72+
Workflow.newActivityStub(
73+
GreetingActivities.class,
74+
new ActivityOptions.Builder()
75+
.setScheduleToCloseTimeout(Duration.ofSeconds(10))
76+
.build());
77+
78+
/**
79+
* Stub used to terminate this workflow run and create the next one with the same ID atomically.
80+
*/
81+
private final GreetingWorkflow continueAsNew =
82+
Workflow.newContinueAsNewStub(GreetingWorkflow.class);
83+
84+
@Override
85+
public void greetPeriodically(String name, Duration delay) {
86+
87+
HelloChild.GreetingChild child =
88+
Workflow.newChildWorkflowStub(HelloChild.GreetingChild.class);
89+
90+
Promise<String> greeting = Async.function(child::composeGreeting, "Hello", name);
91+
92+
System.out.println(greeting.get());
93+
94+
// Loop the predefined number of times then continue this workflow as new.
95+
// This is needed to periodically truncate the history size.
96+
for (int i = 0; i < CONTINUE_AS_NEW_FREQUENCEY; i++) {
97+
activities.greet("Hello " + name + "!");
98+
Workflow.sleep(delay);
99+
}
100+
// Current workflow run stops executing after this call.
101+
continueAsNew.greetPeriodically(name, delay);
102+
}
103+
}
104+
105+
static class GreetingActivitiesImpl implements GreetingActivities {
106+
107+
@Override
108+
public void greet(String greeting) {
109+
System.out.println("From " + Activity.getWorkflowExecution() + ": " + greeting);
110+
}
111+
}
112+
113+
public static void main(String[] args) throws InterruptedException {
114+
// Get a new client
115+
// NOTE: to set a different options, you can do like this:
116+
// ClientOptions.newBuilder().setRpcTimeout(5 * 1000).build();
117+
WorkflowClient workflowClient =
118+
WorkflowClient.newInstance(
119+
new Thrift2ProtoAdapter(IGrpcServiceStubs.newInstance()),
120+
WorkflowClientOptions.newBuilder().setDomain(DOMAIN).build());
121+
// Get worker to poll the task list.
122+
WorkerFactory factory = WorkerFactory.newInstance(workflowClient);
123+
Worker worker = factory.newWorker(TASK_LIST);
124+
// Workflows are stateful. So you need a type to create instances.
125+
worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
126+
// Activities are stateless and thread safe. So a shared instance is used.
127+
worker.registerActivitiesImplementations(new GreetingActivitiesImpl());
128+
// Start listening to the workflow and activity task lists.
129+
factory.start();
130+
131+
// Start a workflow execution. Usually this is done from another program.
132+
// To ensure that this daemon type workflow is always running try to start it periodically
133+
// ignoring the duplicated exception.
134+
// It is only to protect from application level failures.
135+
// Failures of a workflow worker don't lead to workflow failures.
136+
WorkflowExecution execution = null;
137+
while (true) {
138+
// Print reason of failure of the previous run, before restarting.
139+
if (execution != null) {
140+
WorkflowStub workflow = workflowClient.newUntypedWorkflowStub(execution, Optional.empty());
141+
try {
142+
workflow.getResult(Void.class); //
143+
} catch (WorkflowException e) {
144+
System.out.println("Previous instance failed:\n" + Throwables.getStackTraceAsString(e));
145+
}
146+
}
147+
// New stub instance should be created for each new workflow start.
148+
GreetingWorkflow workflow = workflowClient.newWorkflowStub(GreetingWorkflow.class);
149+
try {
150+
execution =
151+
WorkflowClient.start(workflow::greetPeriodically, "World", Duration.ofSeconds(3));
152+
System.out.println("Started " + execution);
153+
} catch (DuplicateWorkflowException e) {
154+
System.out.println("Still running as " + e.getExecution());
155+
} catch (Throwable e) {
156+
e.printStackTrace();
157+
System.exit(1);
158+
}
159+
// This value is so low just for the sample purpose. In production workflow
160+
// it is usually much higher.
161+
Thread.sleep(10000);
162+
}
163+
}
164+
}

0 commit comments

Comments
 (0)