fixing strftime issue

Author: mikehikes

dist/ffiec-data-connect-0.2.0.tar.gz

@@ -7,7 +7,7 @@
 setup(
     name='ffiec-data-connect',
     python_requires='>3.9.0',
-    version='0.2.6',
+    version='0.2.7',
     license='MIT',
     description="Wrapper for the FFIEC's Webservice API",
     readme='README.md',

setup.py

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ffiec-data-connect
-Version: 0.2.0
+Version: 0.2.7
 Summary: Wrapper for the FFIEC's Webservice API
 Home-page: https://github.com/call-report/ffiec-data-connect
 Author: Michael Handelman
@@ -11,6 +11,7 @@ Project-URL: Repo, https://github.com/call-report/ffiec-data-connect
 Project-URL: Additional Info, http://call.report
 Project-URL: Author, https://mikeh.dev
 Keywords: ffiec call report bank regulatory
+Requires-Python: >3.9.0
 Description-Content-Type: text/markdown
 License-File: LICENSE.txt
 
@@ -42,12 +43,16 @@ Data returned from the Webservice may be returned as a native Python data struct
 
 ## Quickstart
 
-__To run this Quick Start, you must have an account on the FFIEC Webservice at https://cdr.ffiec.gov/public/PWS/CreateAccount.aspx?PWS=true__
+1. To run this Quick Start, you must have an account on the FFIEC Webservice at https://cdr.ffiec.gov/public/PWS/CreateAccount.aspx?PWS=true
+2. After you create an account, verify your password, and complete the sign-in process, log into the public web interface here: https://cdr.ffiec.gov/Public/PWS/Login.aspx
+3. When you login, go to the "Account Details" tab. On this screen, look for the _Security Token_. This token is the password that you will use for the login credentials for ffiec-data-connect, __not the password__.
+
+Sample code to login and collect reporting periods:
 
 ```
         from ffiec_data_connect import methods, credentials, ffiec_connection
 
-        creds = credentials.WebserviceCredentials(username="user1234", password="password1234")
+        creds = credentials.WebserviceCredentials(username="USER_NAME_GOES_HERE", password="SECURITY_TOKEN_GOES_HERE")
 
         conn = ffiec_connection.FFIECConnection()
 

src/ffiec_data_connect.egg-info/PKG-INFO

@@ -24,6 +24,23 @@
 validRegexList = [quarterStringRegex, yyyymmddRegex, yyyymmddDashRegex, mmddyyyyRegex]
 
 
+def _create_ffiec_date_from_datetime(indate: datetime) -> str:
+    """Converts a datetime object to a FFIEC-formatted date
+
+    Args:
+        indate (datetime): the date to convert
+
+    Returns:
+        str: the date in FFIEC format
+    """
+    month_str = str(indate.month)
+    day_str = str(indate.day)
+    year_str = str(indate.year)
+    
+    mmddyyyy = month_str + "/" + day_str + "/" + year_str
+    
+    return mmddyyyy
+
 def _convert_any_date_to_ffiec_format(indate: str or datetime) -> str:
     """Converts a string-based date or python datetime object to a FFIEC-formatted date
  
@@ -35,15 +52,15 @@ def _convert_any_date_to_ffiec_format(indate: str or datetime) -> str:
     """
 
     if isinstance(indate, datetime):
-        return indate.strftime("%-m/%-d/%Y")
+        return _create_ffiec_date_from_datetime(indate)
     elif isinstance(indate, str):
         # does the date have two slashes?
         if indate.count("-") == 2:
-            return datetime.strptime(indate, "%Y-%m-%d").strftime("%-m/%-d/%Y")
+            return _create_ffiec_date_from_datetime(datetime.strptime(indate, "%Y-%m-%d"))
         elif indate.count("/") == 2:
-            return datetime.strptime(indate, "%m/%d/%Y").strftime("%-m/%-d/%Y")
+            return _create_ffiec_date_from_datetime(datetime.strptime(indate, "%m/%d/%Y"))
         elif len(indate) == 8:
-            return datetime.strptime(indate, "%Y%m%d").strftime("%-m/%-d/%Y")    
+            return _create_ffiec_date_from_datetime(datetime.strptime(indate, "%Y%m%d"))  
     else:
         # raise an error if we don't have a valid date
         raise(ValueError("Invalid date format. Must be a string in the format of 'YYYY-MM-DD', 'YYYYMMDD', 'MM/DD/YYYY', or a python datetime object"))
@@ -118,10 +135,10 @@ def _is_valid_date_or_quarter(reporting_period: str or datetime) -> bool:
 
 def _return_ffiec_reporting_date(indate: datetime or str) -> str:
     if isinstance(indate, datetime):
-        return indate.strftime("%-m/%-d/%Y")
+        return _create_ffiec_date_from_datetime(indate)
     elif isinstance(indate, str):
         if indate[1] == "Q":
-            return _convert_quarter_to_date(indate).strftime("%-m/%-d/%Y")
+            return _create_ffiec_date_from_datetime(_convert_quarter_to_date(indate))
         else:
             ffiec_date =  _convert_any_date_to_ffiec_format(indate)
             ffiec_date_month = ffiec_date.split("/")[0]

src/ffiec_data_connect/methods.py

@@ -58,6 +58,24 @@ def _process_xml(data: bytes, output_date_format: str):
 
     return ret_data
 
+
+def _create_ffiec_date_from_datetime(indate: datetime) -> str:
+    """Converts a datetime object to a FFIEC-formatted date
+
+    Args:
+        indate (datetime): the date to convert
+
+    Returns:
+        str: the date in FFIEC format
+    """
+    month_str = str(indate.month)
+    day_str = str(indate.day)
+    year_str = str(indate.year)
+    
+    mmddyyyy = month_str + "/" + day_str + "/" + year_str
+    
+    return mmddyyyy
+
 def _process_xbrl_item(name, items, date_format):
     # incoming is a data dictionary
     results = []
@@ -75,7 +93,7 @@ def _process_xbrl_item(name, items, date_format):
 
         # transform the date to the requested date format
         if date_format == 'string_original':
-            quarter = datetime.strptime(quarter, '%Y-%m-%d').strftime('%-m/%-d/%Y')
+            quarter = _create_ffiec_date_from_datetime(datetime.strptime(quarter, '%Y-%m-%d'))
         elif date_format == 'string_yyyymmdd':
             quarter = datetime.strptime(quarter, '%Y-%m-%d').strftime('%Y%m%d')
         elif date_format == 'python_format':