Skip to content

Commit 6147d97

Browse files
author
amechi101
committed
#157 adds warning when global fixture is called
1 parent 1559de9 commit 6147d97

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

fixture.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ var fixture = core.add;
44
var Store = require("./store");
55
require("./xhr");
66
var canReflect = require("can-reflect");
7+
var canDev = require("can-log/dev/dev");
78
var ns = require("can-namespace");
89
// HELPERS START
910

@@ -67,7 +68,14 @@ canReflect.assignMap(fixture, {
6768
});
6869

6970
if(typeof window !== "undefined" && typeof require.resolve !== "function") {
70-
window.fixture = fixture;
71+
// window.fixture = fixture;
72+
73+
window.fixture = function(){
74+
debugger
75+
canDev.warn("You using the global fixture. Make sure you import can-fixture.");
76+
77+
return fixture.apply(this, arguments);
78+
};
7179
}
7280

7381

test/fixture_test.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1980,3 +1980,20 @@ if ("onabort" in XMLHttpRequest._XHR.prototype) {
19801980
stop();
19811981
});
19821982
} // END onabort check
1983+
1984+
1985+
1986+
testHelpers.dev.devOnlyTest("window.fixture warns when called", function() {
1987+
debugger
1988+
var teardown = testHelpers.dev.willWarn(/You using the global fixture\. Make sure you import can-fixture\./, function(message, matched) {
1989+
if(matched) {
1990+
ok(true, "received warning");
1991+
}
1992+
});
1993+
1994+
window.fixture("GET /api/products", function(){
1995+
return {};
1996+
});
1997+
1998+
teardown();
1999+
});

0 commit comments

Comments
 (0)