Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

dependencies vs devDependencies #147

Open
nottrobin opened this issue Dec 13, 2018 · 0 comments
Open

dependencies vs devDependencies #147

nottrobin opened this issue Dec 13, 2018 · 0 comments
Labels
Priority: Low

Comments

@nottrobin
Copy link
Contributor

nottrobin commented Dec 13, 2018 •
edited
Loading

Explain what should count as a "devDependency" and what should count as a "dependency" (e.g. in package.json). This matters for Renovate, which can auto-merge devDependencies. And so, it's important that things like "vanilla-framework" aren't in this

So I propose that we explicitly define "dependencies" as anything that will, in any form, make it into the built site. So this would apply to e.g. Vanilla-framework and global-nav, even though those modules themselves aren't used in the production app - instead their contents is used for building the production assets.
nottrobin referenced this issue in nottrobin/docs.snapcraft.io Dec 14, 2018
@nottrobin
Move built dependencies out of "devDependencies"
7844845 
Rationale here: https://github.com/canonical-webteam/practices/issues/147
nottrobin referenced this issue in canonical/cn.ubuntu.com Jan 14, 2019
@nottrobin
Update node devDependencies and dependencies
3054cdd 
Per https://github.com/canonical-webteam/practices/issues/147,
"dependencies" should contain only and all modules whose content
ultimately makes it into the built application.

This means "vanilla-framework" goes in "dependencies", but "autoprefixer",
"node-sass" etc. are only "devDependencies".
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nottrobin @cristinadresch