Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the side navigation on https://canonical.com/documentation looks kinda funny #1177

Open
petesfrench opened this issue Feb 12, 2024 · 3 comments

Comments

@petesfrench
Copy link
Contributor

petesfrench commented Feb 12, 2024

https://canonical.com/documentation

image

Also the tabs need to be scrolled, I think it would be nicer if they just spanned the whole screen:
image

@mtruj013
Copy link
Contributor

mtruj013 commented Nov 4, 2024

@lyubomir-popov @mattea-turic could you have a look please?

@mattea-turic
Copy link
Collaborator

The side nav does look a little strange, maybe we can figure something out that would work better there @lyubomir-popov ? Also I notice that when the nav bar is open on mobile that scrolling is still enabled (even though it spans full width of screen), so something to consider there as well(?)

As for the tabs, for them to fit small screens, I'm not sure if there's a way around it since we'd have to use a font size smaller than the scale established in the guidelines. For medium screens (added img below), if we rework the side nav then I think allowing for full-width would work fine.

IMG_2568

@lyubomir-popov
Copy link
Contributor

+1, the tabs should span the full width as it is a parent to the sidenav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants