Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please split common converters slice from libc6 gconv slice #368

Open
vpa1977 opened this issue Oct 17, 2024 · 3 comments
Open

Please split common converters slice from libc6 gconv slice #368

vpa1977 opened this issue Oct 17, 2024 · 3 comments
Assignees

Comments

@vpa1977
Copy link

vpa1977 commented Oct 17, 2024

libc6 slice definition splits package into libraries and gconv files.

Fedora implemented proposal[1] to move gconv files into a separate package except most commonly used converters UTF-*, unicode, ISO-8859-1, ISO8859-15, CP1252 and ANSI_X3.110..

Would it be possible to consider splitting gconv slice to have common converters installable?

Note: corresponding Debian bug[2]

[1] https://www.fedoraproject.org/wiki/Changes/Gconv_package_split_in_glibc
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005193

@vpa1977 vpa1977 changed the title libc6 gconv slices please split common converters slice from libc6 gconv slice Oct 17, 2024
@vpa1977 vpa1977 changed the title please split common converters slice from libc6 gconv slice Please split common converters slice from libc6 gconv slice Oct 17, 2024
@rebornplusplus rebornplusplus self-assigned this Oct 17, 2024
@rebornplusplus
Copy link
Member

Hello @vpa1977! Are you looking for something like below?

diff --git a/slices/libc6.yaml b/slices/libc6.yaml
index 3ea1e51..21ba10a 100644
--- a/slices/libc6.yaml
+++ b/slices/libc6.yaml
@@ -40,9 +40,20 @@ slices:
       /usr/lib/*-linux-*/libutil.so.*:

   gconv:
+    essential:
+      - libc6_gconv-core
     contents:
       /usr/lib/*-linux-*/gconv/**:

+  gconv-core:
+    contents:
+      /usr/lib/*-linux-*/gconv/ANSI_X3.110.so:
+      /usr/lib/*-linux-*/gconv/CP1252.so:
+      /usr/lib/*-linux-*/gconv/ISO8859-1.so:
+      /usr/lib/*-linux-*/gconv/ISO8859-15.so:
+      /usr/lib/*-linux-*/gconv/UNICODE.so:
+      /usr/lib/*-linux-*/gconv/UTF-*.so:
+
   copyright:
     contents:
       /usr/share/doc/libc6/copyright:

It works too:

$ chisel cut --release ./ --root out/ libc6_gconv-core
...
$ tree out/
out/
└── usr
    ├── lib
    │   └── x86_64-linux-gnu
    │       └── gconv
    │           ├── ANSI_X3.110.so
    │           ├── CP1252.so
    │           ├── ISO8859-15.so
    │           ├── ISO8859-1.so
    │           ├── UNICODE.so
    │           ├── UTF-16.so
    │           ├── UTF-32.so
    │           └── UTF-7.so
    └── share
        └── doc
            └── libc6
                └── copyright

@vpa1977
Copy link
Author

vpa1977 commented Oct 23, 2024

@rebornplusplus yes, this is perfect, thank you!!!!

@rebornplusplus
Copy link
Member

Ah okay, please feel free to raise a PR. Just so you know, paths do not conflict within the same package or same slice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants