chore: enforce min coverage on internal packages #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbartz
requested review from
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces a minimum code coverage threshold of 85% for internal packages in CI, aligning with the team's agreed-upon standards. The internal/telemetry package, which currently has only 30% coverage, is temporarily excluded from coverage analysis pending a team discussion.
- Excludes low-coverage packages from coverage reporting using a filtered package list
- Adds HTML coverage report generation and artifact upload for better visibility
- Implements a coverage gate that fails the CI pipeline if total coverage drops below 85%
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
florentianayuwono
approved these changes
Nov 26, 2025
yanksyoon
approved these changes
Nov 27, 2025
Member
yanksyoon
left a comment
yanksyoon
left a comment
There was a problem hiding this comment.
LGTM after arturoi's comments, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enforce min coverage on internal packages.
Following issues are spotted:
internal/telemetryhas really low coverage of 30 % at the momentIt has been excluded from coverage report, we need a team follow-up discussion on how to deal with this particular package.
Rationale
Fail if agreed min coverage has not been achieved. Team has agreed to comply with min coverage of 85 %.