-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
Description
Bug Description
A test in cos-configuration-k8s started failing after updating grafana_dashboard library from 0.36 to 0.43. cos-configuration-k8s started failing with:
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/venv/lib/python3.8/site-packages/ops/framework.py", line 1029, in _reemit
2025-05-13T09:10:57.802Z [container-agent] custom_handler(event)
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py", line 1116, in wrapped_function
2025-05-13T09:10:57.802Z [container-agent] return callable(*args, **kwargs) # type: ignore
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/src/charm.py", line 443, in _on_config_changed
2025-05-13T09:10:57.802Z [container-agent] self._common_exit_hook()
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py", line 1116, in wrapped_function
2025-05-13T09:10:57.802Z [container-agent] return callable(*args, **kwargs) # type: ignore
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/src/charm.py", line 210, in _common_exit_hook
2025-05-13T09:10:57.802Z [container-agent] self._update_hash_and_rel_data()
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py", line 1116, in wrapped_function
2025-05-13T09:10:57.802Z [container-agent] return callable(*args, **kwargs) # type: ignore
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/src/charm.py", line 406, in _update_hash_and_rel_data
2025-05-13T09:10:57.802Z [container-agent] self.grafana_dashboards_provider._reinitialize_dashboard_data(inject_dropdowns=False)
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py", line 1116, in wrapped_
function
2025-05-13T09:10:57.802Z [container-agent] return callable(*args, **kwargs) # type: ignore
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1291, in _reinitialize_dashboard_data
2025-05-13T09:10:57.802Z [container-agent] self._update_all_dashboards_from_dir(inject_dropdowns=inject_dropdowns)
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/tempo_coordinator_k8s/v0/charm_tracing.py", line 1116, in wrapped_function
2025-05-13T09:10:57.802Z [container-agent] return callable(*args, **kwargs) # type: ignore
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1268, in update_all_dashboards_from_dir
2025-05-13T09:10:57.802Z [container-agent] CharmedDashboard.load_dashboards_from_dir(
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 1009, in load_dashboards_from_dir
2025-05-13T09:10:57.802Z [container-agent] cls._replace_uid(
2025-05-13T09:10:57.802Z [container-agent] File "/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm/lib/charms/grafana_k8s/v0/grafana_dashboard.py", line 951, in _replace_uid
2025-05-13T09:10:57.802Z [container-agent] dashboard_path.relative_to(charm_dir)
2025-05-13T09:10:57.802Z [container-agent] File "/usr/lib/python3.8/pathlib.py", line 908, in relative_to
2025-05-13T09:10:57.802Z [container-agent] raise ValueError("{!r} does not start with {!r}"
2025-05-13T09:10:57.802Z [container-agent] ValueError: '/var/lib/juju/storage/content-from-git/0/repo/tests/samples/grafana_dashboards/up (with datasource variables).json' does not start with '/var/lib/juju/agents/unit-cos-configuration-k8s-0/charm'
2025-05-13T09:10:58.045Z [container-agent] 2025-05-13 09:10:58 ERROR juju.worker.uniter.operation runhook.go:180 hook "config-changed" (via hook dispatching script: dispatch) failed: exit status 1
To Reproduce
- Run the test enabled in chore: re-enable flaky test cos-configuration-k8s-operator#123
- See the
config-changedhook fail on the test - If you don't get a juju debug-log from the config-failed hook, run the following:
juju ssh cos-configuration-k8s/0
bash
/charm/bin/pebble logs -n 100 | more
Environment
Juju 3.6.5
Ubuntu 24.04
Relevant log output
.Additional context
No response