Skip to content

Commit 997e107

Browse files
sed-ilucabello
andauthored
[doc] Update kubernetes_service_patch.py (#103)
* Update kubernetes_service_patch.py * Bump LIBPATCH * fix ruff usage --------- Co-authored-by: Luca Bello <[email protected]>
1 parent 74f192c commit 997e107

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

lib/charms/observability_libs/v1/kubernetes_service_patch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
This library is designed to enable developers to more simply patch the Kubernetes Service created
77
by Juju during the deployment of a sidecar charm. When sidecar charms are deployed, Juju creates a
88
service named after the application in the namespace (named after the Juju model). This service by
9-
default contains a "placeholder" port, which is 65536/TCP.
9+
default contains a "placeholder" port, which is 65535/TCP.
1010
1111
When modifying the default set of resources managed by Juju, one must consider the lifecycle of the
1212
charm. In this case, any modifications to the default service (created during deployment), will be
@@ -166,7 +166,7 @@ def setUp(self, *unused):
166166

167167
# Increment this PATCH version before using `charmcraft publish-lib` or reset
168168
# to 0 if you are raising the major API version
169-
LIBPATCH = 10
169+
LIBPATCH = 11
170170

171171
ServiceType = Literal["ClusterIP", "LoadBalancer"]
172172

pyproject.toml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,16 @@ target-version = ["py38"]
1414
[tool.ruff]
1515
line-length = 99
1616
extend-exclude = ["__pycache__", "*.egg_info"]
17+
18+
[tool.ruff.lint]
19+
per-file-ignores = {"tests/*" = ["D100","D101","D102","D103"]}
1720
select = ["E", "W", "F", "C", "N", "R", "D", "I001"]
1821
# Ignore E501 because using black creates errors with this
1922
# Ignore D107 Missing docstring in __init__
2023
ignore = ["E501", "D107", "RET504"]
2124
# D100, D101, D102, D103: Ignore missing docstrings in tests
22-
per-file-ignores = {"tests/*" = ["D100","D101","D102","D103"]}
2325

24-
[tool.ruff.pydocstyle]
26+
[tool.ruff.lint.pydocstyle]
2527
convention = "google"
2628

2729
# Static analysis tools configuration

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ deps =
3333
black
3434
ruff
3535
commands =
36-
ruff --fix {[vars]all_path}
36+
ruff check --fix {[vars]all_path}
3737
black {[vars]all_path}
3838

3939
[testenv:lint]
@@ -45,7 +45,7 @@ deps =
4545
commands =
4646
codespell {[vars]lib_path}
4747
codespell .
48-
ruff {[vars]all_path}
48+
ruff check {[vars]all_path}
4949
black --check --diff {[vars]all_path}
5050

5151
[testenv:static-{charm,lib}]

0 commit comments

Comments
 (0)