Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use release version of sdcore github workflows #18

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

gruyaume
Copy link
Collaborator

Description

Use the release version of sdcore-github workflows instead of using the main branch.

Rationale

This will allow to make breaking changes in the workflows without breaking its dependents. More specifically, we are working on building the charm in its independent workflow step instead of having it built in the integration tests. Making such change in the workflows would break every NF CI until they adapt to the new workflow approach. Here we want to avoid this and have the workflow keep on working until we intentionally adopt the new approach.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume requested a review from a team as a code owner April 15, 2024 12:09
@gruyaume gruyaume marked this pull request as draft April 16, 2024 17:24
@gruyaume gruyaume marked this pull request as ready for review April 25, 2024 14:14
@gruyaume gruyaume merged commit 4238dde into main Apr 25, 2024
9 checks passed
@gruyaume gruyaume deleted the dev-cirelease branch April 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants