Skip to content

[BUG] TS error on partial INSERT / UPDATE #461

@siarhei-murkou

Description

@siarhei-murkou

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently TypeScript compilation fails if I do partial INSERT or partial UPDATE, because @cap-js/cds-types expects the whole object to be provided on INSERT, and expects the whole nested object to be provided on UPDATE.

Expected Behavior

I expect deep partial objects to be provided on INSERT & UPDATE instead, in order to make TS compilation be working again.

References

Feel free to clone this git repo (branch: bug/cds-types/issues-461): https://github.com/siarhei-murkou/cds-issues/tree/bug/cds-types/issues-461.

In particular, take a look at the changes in this commit -> siarhei-murkou/cds-issues@90d374b.
And pay your attention on the FIXME comments. 🙂

Versions

@cap-js/asyncapi: 1.0.3
@cap-js/cds-test: 0.4.0
@cap-js/cds-typer: 0.35.0
@cap-js/cds-types: 0.12.0
@cap-js/db-service: 2.1.2
@cap-js/openapi: 1.2.3
@cap-js/sqlite: 2.0.1
@sap/cds: 9.0.4
@sap/cds-compiler: 6.0.14
@sap/cds-dk: 9.0.6
@sap/cds-dk (global): 8.2.2
@sap/cds-fiori: 2.0.1
@sap/cds-foss: 5.0.1
@sap/cds-mtxs: 3.0.1
@sap/eslint-plugin-cds: 3.0.5

Node.js: v20.18.0

Anything else? Logs?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions