Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): support scopes option for Google Sign-In on iOS #440

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

robingenz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

Close #437

@robingenz
Copy link
Member Author

npm i @capacitor-firebase/[email protected]

@robingenz robingenz merged commit 2ea241b into main Sep 27, 2023
2 checks passed
@robingenz robingenz deleted the feat/issue-437 branch September 27, 2023 09:09
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
@RaduMirceaAndrei
Copy link

RaduMirceaAndrei commented Sep 27, 2023

Hi. Just need to change line 40 in GoogleAuthProvideHandler from GIDSignIn.sharedInstance.signIn(withPresenting: controller, scopes: scopes) { [unowned self] result, error in to GIDSignIn.sharedInstance.signIn(withPresenting: controller, hint: nil, additionalScopes: scopes) { (result, error) in or GIDSignIn.sharedInstance.signIn(withPresenting: controller, hint: nil, additionalScopes: scopes) { [unowned self] result, error in.

With that, i was able to build it and i was also presented with the scopes permission screen on iOS

@nkalupahana
Copy link
Contributor

@robingenz ^ the merged code is incorrect

@robingenz
Copy link
Member Author

@nkalupahana Yes, I know (see #437 (comment)). I published a new dev version with a fix: #442 (comment)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: iOS Google Authentication scopes support
3 participants