Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added verifyBeforeUpdateEmail method to Web, iOS, Android #741

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

ewwwgiddings
Copy link
Contributor

Pull request to handle this feature request:
#739

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks very good. Please take a look at my comments.

@ewwwgiddings
Copy link
Contributor Author

ewwwgiddings commented Oct 22, 2024

Thanks! Wasn't sure how far I was off with those.

I just implemented all your suggestions now (with just the one thought about handling exceptions elsewhere as well) and hit the re-request review button.

@ewwwgiddings
Copy link
Contributor Author

I also just updated the newEmail definition to what you liked and added an example in the README.

@ewwwgiddings
Copy link
Contributor Author

Just pushed a commit that adds the callback like the example method.

@ewwwgiddings
Copy link
Contributor Author

Just fixed the prettier issues as well. There were around 25 in unrelated files when using --write on the prettier command as a side note for some time in the future maybe.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be the last changes.

@ewwwgiddings
Copy link
Contributor Author

Changes pushed

Copy link

pkg-pr-new bot commented Oct 23, 2024

Open in Stackblitz

@capacitor-firebase/analytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@741

@capacitor-firebase/app

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@741

@capacitor-firebase/app-check

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@741

@capacitor-firebase/authentication

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@741

@capacitor-firebase/crashlytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@741

@capacitor-firebase/firestore

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@741

@capacitor-firebase/functions

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@741

@capacitor-firebase/messaging

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@741

@capacitor-firebase/performance

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@741

@capacitor-firebase/remote-config

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@741

@capacitor-firebase/storage

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@741

commit: 8de3677

@robingenz
Copy link
Member

@ewwwgiddings Great, thank you! Two points remain before we can merge:

  1. Create a changeset with the commandnpm run changeset. Please use the following text: feat: add `verifyBeforeUpdateEmail` method
  2. Test your implementation using this dev release:
    npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@741
    

@ewwwgiddings
Copy link
Contributor Author

Pushed the changeset. As far as testing I'm currently unable to test anything but web with my setup. Eventually I'll get to a point I have all the environments set up but atm it's probably a couple months away.

@robingenz
Copy link
Member

@ewwwgiddings No problem. I will test it on Android and iOS before the next release. Thank you for your contribution!

@robingenz robingenz merged commit 7af2032 into capawesome-team:main Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants