-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added verifyBeforeUpdateEmail method to Web, iOS, Android #741
Conversation
…cuments to include the new method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks very good. Please take a look at my comments.
packages/authentication/ios/Plugin/FirebaseAuthenticationPlugin.m
Outdated
Show resolved
Hide resolved
...n/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthentication.java
Outdated
Show resolved
Hide resolved
...n/java/io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthentication.java
Outdated
Show resolved
Hide resolved
… ordering. Update version number.
Thanks! Wasn't sure how far I was off with those. I just implemented all your suggestions now (with just the one thought about handling exceptions elsewhere as well) and hit the re-request review button. |
I also just updated the |
.../io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java
Outdated
Show resolved
Hide resolved
Just pushed a commit that adds the callback like the example method. |
Just fixed the prettier issues as well. There were around 25 in unrelated files when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be the last changes.
.../io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java
Outdated
Show resolved
Hide resolved
.../io/capawesome/capacitorjs/plugins/firebase/authentication/FirebaseAuthenticationPlugin.java
Outdated
Show resolved
Hide resolved
Changes pushed |
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
@ewwwgiddings Great, thank you! Two points remain before we can merge:
|
Pushed the changeset. As far as testing I'm currently unable to test anything but web with my setup. Eventually I'll get to a point I have all the environments set up but atm it's probably a couple months away. |
@ewwwgiddings No problem. I will test it on Android and iOS before the next release. Thank you for your contribution! |
Pull request to handle this feature request:
#739
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).