`bundle check` always fails (and why do we even need this extra step?)

[ayoubkhobalatte]

What does this check in bundler.cap (like 31) do

unless test(:bundle, :check, *options)

This is always returns false for me and therefore bundler:install gets skipped.

[mattbrictson]

Can you try running the command via SSH? For example, I see:

$ bundle check
The Gemfile's dependencies are satisfied

The documentation says:

check searches the local machine for each of the gems requested in the Gemfile. If all gems are found, Bundler prints a success message and exits with a status of 0. If not, the first missing gem is listed and Bundler exits status 1.

In other words, if bundle check succeeds, that means no gems need to be installed. Therefore bundle install is unnecessary and can be skipped.

Are you seeing a situation where bundle check succeeds even though gems are missing?

[ayoubkhobalatte]

My dependencies didn't change so it makes sense now. I was under the impression bundle would run on all deploys, regardless of wether the Gemfile has changed or not.

So this is not a bug, just my bad. But It would be nice to print All gems are statified intsead of nothing, I think. Closing this.

[LoveEachDay]

Why not options << "--without #{fetch(:bundle_without)}" if fetch(:bundle_without) set before bundle check is executed?

[mattbrictson]

bundle check does not accept the --without option.

[LoveEachDay]

So bundle check will always fail in production, because bundle install without the development and test group.

[mattbrictson]

Good question.

bundle check honors the settings stored in .bundle/config from previous bundle install executions. So yes, it will properly ignore development and test groups and not fail in production.

I just verified this in a production environment that was deployed with capistrano-bundler.

$ bundle check
The Gemfile's dependencies are satisfied
$ cat .bundle/config 
---
BUNDLE_PATH: "/home/deployer/apps/[redacted]/shared/bundle"
BUNDLE_DISABLE_SHARED_GEMS: "true"
BUNDLE_RETRY: "3"
BUNDLE_FROZEN: "1"
BUNDLE_WITHOUT: "development:test"

The check command succeeds, even though gems in the test group are not installed.

$ bundle show capybara
Could not find gem 'capybara'.
Did you mean capybara?

So it seems to work as intended.

[mattbrictson]

Of course, this probably only works if you are symlinking .bundle/config using Capistrano's :linked_dirs (as I do for all my deployments). Perhaps this should be mentioned in the README?

I am also skeptical that bundle check actually saves any time. After all, bundle install will exit immediately if there are no gems to install, right? It does not seem necessary, but perhaps I am missing something.

I'll reopen this issue since it seems there is more to discuss here. I'm interested in any further thoughts or suggestions you have on this topic.

[fbluemel]

For me, bundle install would waste time on every deploy and I didn't understand why. Without this issue, I still wouldn't have .bundle in the :linked_dirs so yes, I think this really should be in the README.

In this particular deployment the bundle install takes 4 seconds to realize that nothing needs to be installed; bundle check knows that instantly. So bundle check does indeed save time. (In this case deployment time is <10s, so an extra 4 weren't exactly nothing.)

[mattbrictson]

Thanks for the feedback and real-world data, @fbluemel. I agree we need to update the README. I just opened #96 to track this. Do you have time to contribute a PR?