Skip to content

Commit 3bb8be9

Browse files
committed
angular: remove module.ts files of the diagrams
1 parent 4862026 commit 3bb8be9

File tree

18 files changed

+42
-101
lines changed

18 files changed

+42
-101
lines changed

packages/angular/README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,8 @@ The required styles should be imported from `@carbon/charts-angular/dist/styles.
4343

4444
## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry
4545

46-
This package uses IBM Telemetry to collect de-identified and anonymized metrics
47-
data. By installing this package as a dependency you are agreeing to telemetry
48-
collection. To opt out, see
46+
This package uses IBM Telemetry to collect de-identified and anonymized metrics data. By installing
47+
this package as a dependency you are agreeing to telemetry collection. To opt out, see
4948
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
5049

5150
For more information on the data being collected, please see the

packages/angular/src/index.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,15 @@ export {
4040
CardNodeLabelComponent,
4141
CardNodeSubtitleComponent,
4242
CardNodeTitleComponent,
43-
CardNodeModule, // <-- Module
4443
EdgeComponent,
45-
EdgeModule, // <-- Module
4644
MarkerArrowLeftComponent,
4745
MarkerArrowRightComponent,
4846
MarkerComponent,
4947
MarkerDiamondComponent,
50-
MarkerModule, // <-- Module
5148
MarkerShapeNodeComponent,
5249
MarkerSquareComponent,
5350
MarkerTeeComponent,
54-
ShapeNodeComponent,
55-
ShapeNodeModule // <-- Module
51+
ShapeNodeComponent
5652
} from './lib'
5753

5854
// Republish essential types from core so it's not a required dependency

packages/angular/src/lib/diagrams/edges/edge.module.ts

-11
This file was deleted.

packages/angular/src/lib/diagrams/index.ts

+9-13
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,15 @@ export {
55
MarkerShapeNodeComponent,
66
MarkerDiamondComponent,
77
MarkerSquareComponent,
8-
MarkerTeeComponent,
9-
MarkerModule
10-
} from './edges/marker/marker.module'
8+
MarkerTeeComponent
9+
} from './edges/marker/marker.component'
1110

12-
export { EdgeComponent, EdgeModule } from './edges/edge.module'
11+
export { EdgeComponent } from './edges/edge.component'
1312

14-
export {
15-
CardNodeComponent,
16-
CardNodeColumnComponent,
17-
CardNodeLabelComponent,
18-
CardNodeSubtitleComponent,
19-
CardNodeTitleComponent,
20-
CardNodeModule
21-
} from './nodes/cards/card-node.module'
13+
export { CardNodeComponent } from './nodes/cards/card-node.component'
14+
export { CardNodeColumnComponent } from './nodes/cards/card-node-column.component'
15+
export { CardNodeLabelComponent } from './nodes/cards/card-node-label.component'
16+
export { CardNodeTitleComponent } from './nodes/cards/card-node-title.component'
17+
export { CardNodeSubtitleComponent } from './nodes/cards/card-node-subtitle.component'
2218

23-
export { ShapeNodeComponent, ShapeNodeModule } from './nodes/shape/shape-node.module'
19+
export { ShapeNodeComponent } from './nodes/shape/shape-node.component'

packages/angular/src/lib/diagrams/nodes/cards/card-node.module.ts

-33
This file was deleted.

packages/angular/src/lib/diagrams/nodes/shape/shape-node.module.ts

-11
This file was deleted.

packages/angular/src/lib/index.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,13 @@ export {
3434
CardNodeLabelComponent,
3535
CardNodeSubtitleComponent,
3636
CardNodeTitleComponent,
37-
CardNodeModule,
3837
EdgeComponent,
39-
EdgeModule,
4038
MarkerArrowLeftComponent,
4139
MarkerArrowRightComponent,
4240
MarkerComponent,
4341
MarkerDiamondComponent,
44-
MarkerModule,
4542
MarkerShapeNodeComponent,
4643
MarkerSquareComponent,
4744
MarkerTeeComponent,
48-
ShapeNodeComponent,
49-
ShapeNodeModule
45+
ShapeNodeComponent
5046
} from './diagrams'

packages/core/README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ The required styles should be imported from `@carbon/charts/dist/styles.css`.
3737

3838
## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry
3939

40-
This package uses IBM Telemetry to collect de-identified and anonymized metrics
41-
data. By installing this package as a dependency you are agreeing to telemetry
42-
collection. To opt out, see
40+
This package uses IBM Telemetry to collect de-identified and anonymized metrics data. By installing
41+
this package as a dependency you are agreeing to telemetry collection. To opt out, see
4342
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
4443
For more information on the data being collected, please see the
4544
[IBM Telemetry documentation](https://github.com/ibm-telemetry/telemetry-js/tree/main#ibm-telemetry-collection-basics).

packages/core/src/components/essentials/highlights.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,10 @@ export class Highlight extends Component {
3939
})
4040

4141
// Grab container SVG
42-
const svg = this.getComponentContainer({
42+
const svg = this.getComponentContainer({
4343
ariaLabel: 'highlight areas',
44-
withinChartClip: true })
44+
withinChartClip: true
45+
})
4546

4647
// Update data on all axis highlight groups
4748
const highlightAxisGroups = svg

packages/core/src/components/graphs/bar-grouped.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ export class GroupedBar extends Bar {
3636
this.setGroupScale()
3737

3838
// Grab container SVG
39-
const svg = this.getComponentContainer({ ariaLabel: 'grouped bar graphs', withinChartClip: true })
39+
const svg = this.getComponentContainer({
40+
ariaLabel: 'grouped bar graphs',
41+
withinChartClip: true
42+
})
4043

4144
const allDataLabels = uniq(
4245
displayData.map((datum: any) => {

packages/core/src/components/graphs/bar-stacked.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ export class StackedBar extends Bar {
2121

2222
render(animate: boolean) {
2323
// Grab container SVG
24-
const svg = this.getComponentContainer({ ariaLabel: 'stacked bar graphs', withinChartClip: true })
24+
const svg = this.getComponentContainer({
25+
ariaLabel: 'stacked bar graphs',
26+
withinChartClip: true
27+
})
2528

2629
// Chart options mixed with the internal configurations
2730
const options = this.getOptions()

packages/core/src/components/graphs/gauge.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ export class Gauge extends Component {
8282
render(animate = true) {
8383
const svg = this.getComponentContainer({
8484
ariaLabel: 'gauge graph'
85-
}).attr('width', '100%').attr('height', '100%')
85+
})
86+
.attr('width', '100%')
87+
.attr('height', '100%')
8688
const options = this.getOptions()
8789

8890
const value = this.getValue()

packages/core/src/components/graphs/treemap.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export class Treemap extends Component {
6161

6262
render(animate = true) {
6363
const svg = this.getComponentContainer({
64-
ariaLabel: 'treemap',
64+
ariaLabel: 'treemap'
6565
})
6666

6767
this.model.getData()

packages/core/src/components/graphs/wordcloud.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ export class WordCloud extends Component {
2323
const self = this
2424
const svg = this.getComponentContainer({
2525
ariaLabel: 'word cloud'
26-
}).attr('width', '100%').attr('height', '100%')
26+
})
27+
.attr('width', '100%')
28+
.attr('height', '100%')
2729

2830
const displayData = this.model.getDisplayData()
2931
const fontSizeScale = this.getFontSizeScale(displayData)

packages/core/src/components/layout/layout.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,9 @@ export class LayoutComponent extends Component {
131131

132132
// if parent is missing aria-label, set it to the title of the parent
133133
if (isRenderingSVG && !selection.select('svg.layout-svg-wrapper').attr('aria-label')) {
134-
selection.select('svg.layout-svg-wrapper').attr('aria-label', options?.accessibility?.svgAriaLabel || options?.title)
134+
selection
135+
.select('svg.layout-svg-wrapper')
136+
.attr('aria-label', options?.accessibility?.svgAriaLabel || options?.title)
135137
}
136138

137139
// Render preffered & fixed items

packages/react/README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ The required styles should be imported from `@carbon/charts-react/dist/styles.cs
3737

3838
## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry
3939

40-
This package uses IBM Telemetry to collect de-identified and anonymized metrics
41-
data. By installing this package as a dependency you are agreeing to telemetry
42-
collection. To opt out, see
40+
This package uses IBM Telemetry to collect de-identified and anonymized metrics data. By installing
41+
this package as a dependency you are agreeing to telemetry collection. To opt out, see
4342
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
4443
For more information on the data being collected, please see the
4544
[IBM Telemetry documentation](https://github.com/ibm-telemetry/telemetry-js/tree/main#ibm-telemetry-collection-basics).

packages/svelte/README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -262,9 +262,8 @@ let chart: ChartProps['chart'] = null
262262

263263
## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry
264264

265-
This package uses IBM Telemetry to collect de-identified and anonymized metrics
266-
data. By installing this package as a dependency you are agreeing to telemetry
267-
collection. To opt out, see
265+
This package uses IBM Telemetry to collect de-identified and anonymized metrics data. By installing
266+
this package as a dependency you are agreeing to telemetry collection. To opt out, see
268267
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
269268
For more information on the data being collected, please see the
270269
[IBM Telemetry documentation](https://github.com/ibm-telemetry/telemetry-js/tree/main#ibm-telemetry-collection-basics).

packages/vue/README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,8 @@ The required styles should be imported from `@carbon/charts-vue/styles.css`.
4343

4444
## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry
4545

46-
This package uses IBM Telemetry to collect de-identified and anonymized metrics
47-
data. By installing this package as a dependency you are agreeing to telemetry
48-
collection. To opt out, see
46+
This package uses IBM Telemetry to collect de-identified and anonymized metrics data. By installing
47+
this package as a dependency you are agreeing to telemetry collection. To opt out, see
4948
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
5049
For more information on the data being collected, please see the
5150
[IBM Telemetry documentation](https://github.com/ibm-telemetry/telemetry-js/tree/main#ibm-telemetry-collection-basics).

0 commit comments

Comments
 (0)