Skip to content

Commit 626fd99

Browse files
committed
Merge branch 'master' of github.com:IBM/carbon-components-svelte
2 parents 36987b2 + e9016a5 commit 626fd99

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
<!-- ## Unreleased -->
99

10+
## [0.25.1](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.25.1) - 2020-11-28
11+
12+
**Fixes**
13+
14+
- set `selectedResultIndex` in HeaderSearch when clicking a result ([PR #430](https://github.com/IBM/carbon-components-svelte/pull/430), [issue #429](https://github.com/IBM/carbon-components-svelte/issues/429))
15+
1016
## [0.25.0](https://github.com/IBM/carbon-components-svelte/releases/tag/v0.25.0) - 2020-11-27
1117

1218
**Features**

COMPONENT_INDEX.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Component Index
22

3-
> 155 components exported from [email protected].0.
3+
> 155 components exported from [email protected].1.
44
55
## Components
66

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "carbon-components-svelte",
3-
"version": "0.25.0",
3+
"version": "0.25.1",
44
"license": "Apache-2.0",
55
"author": "IBM",
66
"description": "Svelte implementation of the Carbon Design System",

src/UIShell/HeaderSearch.svelte

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
/** Specify the selected result index */
2727
export let selectedResultIndex = 0;
2828
29-
import { createEventDispatcher } from "svelte";
29+
import { createEventDispatcher, tick } from "svelte";
3030
import Close20 from "carbon-icons-svelte/lib/Close20/Close20.svelte";
3131
import Search20 from "carbon-icons-svelte/lib/Search20/Search20.svelte";
3232
@@ -223,19 +223,21 @@
223223
on:focus
224224
on:blur
225225
on:keydown
226-
on:keydown="{({ key }) => {
227-
switch (key) {
226+
on:keydown="{(e) => {
227+
switch (e.key) {
228228
case 'Enter':
229229
selectResult();
230230
break;
231231
case 'ArrowDown':
232+
e.preventDefault();
232233
if (selectedResultIndex === results.length - 1) {
233234
selectedResultIndex = 0;
234235
} else {
235236
selectedResultIndex += 1;
236237
}
237238
break;
238239
case 'ArrowUp':
240+
e.preventDefault();
239241
if (selectedResultIndex === 0) {
240242
selectedResultIndex = results.length - 1;
241243
} else {
@@ -270,7 +272,11 @@
270272
role="menuitem"
271273
href="{result.href}"
272274
class:selected="{selectedId === `search-menuitem-${i}`}"
273-
on:click|preventDefault="{selectResult}"
275+
on:click|preventDefault="{async () => {
276+
selectedResultIndex = i;
277+
await tick();
278+
selectResult();
279+
}}"
274280
>
275281
<slot result="{result}" index="{i}">
276282
{result.text}

0 commit comments

Comments
 (0)