Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Vertical tab border #878

Open
1 task
kingtraceyj opened this issue Nov 18, 2024 · 1 comment
Open
1 task

[Bug]: Vertical tab border #878

kingtraceyj opened this issue Nov 18, 2024 · 1 comment
Labels
component: tabs figma kit kit: figma role: design ✏️ type: bug 🐛

Comments

@kingtraceyj
Copy link
Member

kingtraceyj commented Nov 18, 2024 •
edited by laurenmrice
Loading

Detailed description

In the storybook, the vertical selected tab doesn't have border on the right side, while the Figma component still has it.

  • Selected vertical tab should not have border right—need to take out border-right in selected variant.
@kingtraceyj kingtraceyj moved this to ⏱ Backlog in Design System Nov 18, 2024
@thyhmdo
Copy link
Member

thyhmdo commented Nov 18, 2024 •
edited
Loading

Possible solution:

  1. Lose the Fill and the Stroke on the high level (A)
  2. Add a Spacing layer between the Vertical tab items. Add back the Fill and the Stroke. Set the width and height Fill (B)

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabs figma kit kit: figma role: design ✏️ type: bug 🐛
Projects
Design System
Status: ⏱ Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kingtraceyj @thyhmdo