Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Status Indicator] General discussion around it #16253

Closed
Kritvi-bhatia17 opened this issue Apr 24, 2024 · 13 comments
Closed

[Status Indicator] General discussion around it #16253

Kritvi-bhatia17 opened this issue Apr 24, 2024 · 13 comments

Comments

@Kritvi-bhatia17
Copy link
Contributor

Kritvi-bhatia17 commented Apr 24, 2024

The problem

  1. New status indicator icons are available in the Figma kit, but they are not present in our documentation or code.

  2. The padding differs between the two icons. Why wasn't the size reduced instead of altering the design?

image


To be discussed

  1. Existence in Code: These don't exist in code (beyond the icons that should all be in our icons package). Carbon for IBM Products has a component, its definitely come up before about either creating or moving to core.

  2. Guidance for Icons (for dev): The status indicators were contributed to Figma, and users can use the guidance to configure the icons themselves in code.

  3. Icon Design and Sizing: The shape indicator pulls icons from the icon library without altering the size or design. It might be worth revisiting some of the icon designs to standardize the sizing and SVG naming convention.


Ref:

Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Status Indicator] Not Present in the Code [Status Indicator] Icons not present in the code Apr 24, 2024
@Kritvi-bhatia17
Copy link
Contributor Author

Kritvi-bhatia17 commented Apr 24, 2024

Hey @Shobhith-sridhar! Following our last discussion, I've talked with the team and we've had several conversations since then. Just wanted to keep you in the loop and you can keep an eye on this issue for further updates.

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Status Indicator] Icons not present in the code Status Indicator] General discussion around it to figure out a few things Apr 24, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title Status Indicator] General discussion around it to figure out a few things [Status Indicator] General discussion around it to figure out a few things Apr 24, 2024
@Shobhith-sridhar
Copy link

@Kritvi-bhatia17 Can you please tag me in this issue?

@Kritvi-bhatia17
Copy link
Contributor Author

Related issue

@Kritvi-bhatia17 Kritvi-bhatia17 changed the title [Status Indicator] General discussion around it to figure out a few things [Status Indicator] General discussion around it May 2, 2024
@Shobhith-sridhar
Copy link

Shobhith-sridhar commented May 6, 2024

I have a few more questions @Kritvi-bhatia17 :
So these are some status icons (1st picture) one of our dev teams is using in their deployment environment. We are currently changing these to comply with Carbon colors.

image
image

I want to make sure these icons (2nd picture) (except the icon in this issue, incomplete) are available for the developers to use (ASAP?).

@Shobhith-sridhar
Copy link

If these are available (2nd picture above), then I can use this icon (screenshot below) instead of the one currently in issue (incomplete)

image

Alternatively I could also use these two (bottom screenshot) to represent Paired and Unpaired, but I'm not sure if we can change the color from yellow to green? and if this icon is available for the devs to use right now.

image

@aubrey-oneal
Copy link
Member

aubrey-oneal commented May 6, 2024

A few more resources:

@Kritvi-bhatia17
Copy link
Contributor Author

Hey @Shobhith-sridhar, thanks for bringing this up. Developers can use status shapes and icons them via SVG for now. Here are the steps:

  1. Download the the SVG you need if it isn't already in your code
  2. Add the color tokens documented here and read the usage guidance as needed
  3. Reach out if you have any questions!

We have an item on our roadmap to code these up as full components and fix some confusion, but this is probably coming in Q3. As for understanding the disparity between status indicators and shapes, as mentioned by
@aubrey.oneal, you can find more details over here.

@Kritvi-bhatia17
Copy link
Contributor Author

  1. If these are available (2nd picture above), then I can use this icon (screenshot below) instead of the one currently in issue (incomplete)

  2. Alternatively I could also use these two (bottom screenshot) to represent Paired and Unpaired, but I'm not sure if we can change the color from yellow to green? and if this icon is available for the devs to use right now.

Hi @Shobhith-sridhar! In response to your questions:

  1. I noticed that the gray-colored icon used here doesn't seem to align with the standard, as typically gray indicates draft or disabled status.
    image

  2. It's crucial to opt for colors that closely adhere to the recommended usage guidelines. Therefore, it's advisable to refrain from introducing new color and shape combinations not specified here.

Moreover, you can join our office hours session if you'd like to discuss and review your designs with input from multiple designers!

@Shobhith-sridhar
Copy link

@aubrey-oneal @Kritvi-bhatia17 Thank you so much for your inputs. I'll talk to our devs to decide the best plan of action.

Please keep me posted if any update is being made to this issue 💫

@alexandrutatarciuc
Copy link

In my team, there's an ongoing confusion regarding status indicators, more precisely the "Caution minor" status indicator.
As we can see in the Figma file, the fill of the icon is $support-warning, whereas the inner path is "hardcoded" to black.
image
image

Some people consider this hardcoding to be done on purpose, while others believe that this is an inconsistency since this "black" color should be a token instead (for example, $support-warning-complimentary).
This issue seems to be outlined here #13429.

but we have been telling [developers] they need to hardcode it for now.

We are unsure if this is intentional or an inconsistency. It would be very helpful if someone could clarify this for us :)

@Kritvi-bhatia17
Copy link
Contributor Author

Hi @alexandrutatarciuc! The inner fills are hardcoded to black or white for accessibility reasons, ensuring optimal contrast across different themes. Currently, there isn't a color token available to achieve this, but we'll explore options for addressing this.

@alexandrutatarciuc
Copy link

@Kritvi-bhatia17 Thanks for the prompt reply! It makes sense why it is black or white. I hope there'll be a solution that would align better with the rest of CDS' design practices.
Thanks for considering my feedback!

@laurenmrice laurenmrice moved this from ⏱ Backlog to 🪆 Needs Refined in Design System Jun 27, 2024
@laurenmrice laurenmrice closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@github-project-automation github-project-automation bot moved this from 🪆 Needs Refined to ✅ Done in Design System Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

6 participants