feat: stop closing the app on threat detection (temporary solution) (#1161)

Author: iFergal

android/app/capacitor.build.gradle

@@ -24,7 +24,6 @@ dependencies {
     implementation project(':capacitor-splash-screen')
     implementation project(':capacitor-status-bar')
     implementation project(':evva-capacitor-secure-storage-plugin')
-    implementation project(':jimcase-capacitor-exit-app')
     implementation project(':capacitor-freerasp')
     implementation project(':capacitor-native-settings')
     implementation project(':capacitor-plugin-safe-area')

android/capacitor.settings.gradle

@@ -47,9 +47,6 @@ project(':capacitor-status-bar').projectDir = new File('../node_modules/@capacit
 include ':evva-capacitor-secure-storage-plugin'
 project(':evva-capacitor-secure-storage-plugin').projectDir = new File('../node_modules/@evva/capacitor-secure-storage-plugin/android')
 
-include ':jimcase-capacitor-exit-app'
-project(':jimcase-capacitor-exit-app').projectDir = new File('../node_modules/@jimcase/capacitor-exit-app/android')
-
 include ':capacitor-freerasp'
 project(':capacitor-freerasp').projectDir = new File('../node_modules/capacitor-freerasp/android')
 

ios/App/Podfile

@@ -26,7 +26,6 @@ def capacitor_pods
   pod 'CapacitorSplashScreen', :path => '../../node_modules/@capacitor/splash-screen'
   pod 'CapacitorStatusBar', :path => '../../node_modules/@capacitor/status-bar'
   pod 'EvvaCapacitorSecureStoragePlugin', :path => '../../node_modules/@evva/capacitor-secure-storage-plugin'
-  pod 'JimcaseCapacitorExitApp', :path => '../../node_modules/@jimcase/capacitor-exit-app'
   pod 'CapacitorFreerasp', :path => '../../node_modules/capacitor-freerasp'
   pod 'CapacitorNativeSettings', :path => '../../node_modules/capacitor-native-settings'
   pod 'CapacitorPluginSafeArea', :path => '../../node_modules/capacitor-plugin-safe-area'

ios/App/Podfile.lock

@@ -65,8 +65,6 @@ PODS:
     - GoogleUtilities/Logger
     - GoogleUtilities/Privacy
   - GTMSessionFetcher/Core (3.5.0)
-  - JimcaseCapacitorExitApp (1.0.7):
-    - Capacitor
   - MLImage (1.0.0-beta6)
   - MLKitBarcodeScanning (6.0.0):
     - MLKitCommon (~> 12.0)
@@ -119,7 +117,6 @@ DEPENDENCIES:
   - "CapacitorSplashScreen (from `../../node_modules/@capacitor/splash-screen`)"
   - "CapacitorStatusBar (from `../../node_modules/@capacitor/status-bar`)"
   - "EvvaCapacitorSecureStoragePlugin (from `../../node_modules/@evva/capacitor-secure-storage-plugin`)"
-  - "JimcaseCapacitorExitApp (from `../../node_modules/@jimcase/capacitor-exit-app`)"
 
 SPEC REPOS:
   trunk:
@@ -179,8 +176,6 @@ EXTERNAL SOURCES:
     :path: "../../node_modules/@capacitor/status-bar"
   EvvaCapacitorSecureStoragePlugin:
     :path: "../../node_modules/@evva/capacitor-secure-storage-plugin"
-  JimcaseCapacitorExitApp:
-    :path: "../../node_modules/@jimcase/capacitor-exit-app"
 
 SPEC CHECKSUMS:
   AparajitaCapacitorBiometricAuth: 3057403ee3e9e390e57bfb92b576f439157951b8
@@ -208,7 +203,6 @@ SPEC CHECKSUMS:
   GoogleToolboxForMac: d1a2cbf009c453f4d6ded37c105e2f67a32206d8
   GoogleUtilities: 26a3abef001b6533cf678d3eb38fd3f614b7872d
   GTMSessionFetcher: 5aea5ba6bd522a239e236100971f10cb71b96ab6
-  JimcaseCapacitorExitApp: 499b429827d7d0cacf1b7a0faf18bf88e4b6cc78
   MLImage: 0ad1c5f50edd027672d8b26b0fee78a8b4a0fc56
   MLKitBarcodeScanning: 0a3064da0a7f49ac24ceb3cb46a5bc67496facd2
   MLKitCommon: 07c2c33ae5640e5380beaaa6e4b9c249a205542d
@@ -219,6 +213,6 @@ SPEC CHECKSUMS:
   SQLCipher: 77fbe633cd84db04b07876dd50766b4924b57d61
   ZIPFoundation: b8c29ea7ae353b309bc810586181fd073cb3312c
 
-PODFILE CHECKSUM: ef0d222c85763e963d3ab216ae37e81f4007042b
+PODFILE CHECKSUM: edddec9e8109b205b25d5fc1413526aaa8b9f97f
 
 COCOAPODS: 1.15.2

ios/xcconfig-overwrites/JimcaseCapacitorExitApp/JimcaseCapacitorExitApp.xcconfig

@@ -43,7 +43,6 @@
     "@ionic/react": "^8.4.3",
     "@ionic/react-router": "^8.4.3",
     "@ionic/storage": "^3.0.6",
-    "@jimcase/capacitor-exit-app": "^1.0.7",
     "@reduxjs/toolkit": "^1.9.5",
     "bip39": "^3.0.4",
     "capacitor-freerasp": "^1.10.0",

package-lock.json

@@ -22,11 +22,6 @@ export enum ThreatName {
   DEVICE_ID = "Device ID",
 }
 
-export const EMULATOR_THREATS = [
-  ThreatName.SIMULATOR,
-  ThreatName.SECURE_HARDWARE_NOT_AVAILABLE,
-];
-
 export interface ThreatCheck {
   name: ThreatName;
   description: string;

package.json

@@ -4,7 +4,6 @@ import { Provider } from "react-redux";
 import { MemoryRouter } from "react-router-dom";
 import configureStore from "redux-mock-store";
 import { startFreeRASP } from "capacitor-freerasp";
-import { ExitApp } from "@jimcase/capacitor-exit-app";
 import { IdentifierService } from "../core/agent/services";
 import Eng_Trans from "../locales/en/en.json";
 import { TabsRoutePath } from "../routes/paths";
@@ -22,12 +21,6 @@ import {
 } from "./globals/constants";
 import { InitializationPhase } from "../store/reducers/stateCache/stateCache.types";
 
-jest.mock("@jimcase/capacitor-exit-app", () => ({
-  ExitApp: {
-    exitApp: jest.fn(),
-  },
-}));
-
 jest.mock("capacitor-freerasp", () => ({
   startFreeRASP: jest.fn(),
 }));
@@ -903,33 +896,7 @@ describe("System threat alert", () => {
     });
   });
 
-  test("Catch a threat and close the app on start", async () => {
-    startFreeRASPMock = startFreeRASP as jest.Mock;
-    startFreeRASPMock.mockResolvedValue(true);
-
-    render(
-      <Provider store={storeMocked}>
-        <App />
-      </Provider>
-    );
-
-    await waitFor(() => {
-      expect(startFreeRASPMock).toHaveBeenCalled();
-    });
-
-    await act(async () => {
-      const privilegedAccessAction = (startFreeRASPMock.mock.calls[0][1] as any)
-        .privilegedAccess;
-
-      privilegedAccessAction();
-    });
-
-    await waitFor(() => {
-      expect(ExitApp.exitApp).toBeCalled();
-    });
-  });
-
-  test("Catch emulator threat and avoid closing the app", async () => {
+  test("Catch a threat and show SystemThreatAlert", async () => {
     startFreeRASPMock = startFreeRASP as jest.Mock;
     startFreeRASPMock.mockResolvedValue(true);
 
@@ -953,11 +920,10 @@ describe("System threat alert", () => {
     await waitFor(() => {
       expect(getByText("Threats Detected")).toBeVisible();
       expect(getByText(Eng_Trans.systemthreats.rules.simulator)).toBeVisible();
-      expect(ExitApp.exitApp).not.toBeCalled();
     });
   });
 
-  test("Catches a threat and close the app after renders SetUserName modal", async () => {
+  test("Catches a threat after renders SetUserName modal", async () => {
     const initialState = {
       stateCache: {
         routes: [{ path: TabsRoutePath.ROOT }],

src/security/freerasp.ts

@@ -10,7 +10,6 @@ import {
 } from "@ionic/react";
 import { IonReactRouter } from "@ionic/react-router";
 import { StrictMode, useEffect, useState } from "react";
-import { ExitApp } from "@jimcase/capacitor-exit-app";
 import { SafeArea } from "capacitor-plugin-safe-area";
 import { Routes } from "../routes";
 import { useAppDispatch, useAppSelector } from "../store/hooks";
@@ -43,12 +42,7 @@ import {
 } from "./globals/constants";
 import { InitializationPhase } from "../store/reducers/stateCache/stateCache.types";
 import { LoadingType } from "./pages/LoadingPage/LoadingPage.types";
-import {
-  EMULATOR_THREATS,
-  initializeFreeRASP,
-  ThreatCheck,
-  ThreatName,
-} from "../security/freerasp";
+import { initializeFreeRASP, ThreatCheck } from "../security/freerasp";
 import { SystemThreatAlert } from "./pages/SystemThreatAlert/SystemThreatAlert";
 import { ConfigurationService } from "../core/configuration";
 import { i18n } from "../i18n";
@@ -93,22 +87,6 @@ const App = () => {
     initConfiguration();
   }, []);
 
-  const checkSecurity = () => {
-    if (isFreeRASPInitialized && Capacitor.isNativePlatform()) {
-      const threats = threatsDetected.filter(
-        (threat) => !EMULATOR_THREATS.includes(threat.name)
-      );
-      if (threats.length > 0) {
-        ExitApp.exitApp();
-      }
-    }
-  };
-
-  useEffect(() => {
-    if (!Capacitor.isNativePlatform()) return;
-    checkSecurity();
-  }, [isFreeRASPInitialized, threatsDetected]);
-
   useEffect(() => {
     const handleUnknownPromiseError = (event: PromiseRejectionEvent) => {
       event.preventDefault();