Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement --branch, --tag and --rev #1165

Open
NobodyXu opened this issue Jun 23, 2023 · 2 comments
Open

feat: Implement --branch, --tag and --rev #1165

NobodyXu opened this issue Jun 23, 2023 · 2 comments
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Jun 23, 2023

Yeah and that will be compatible with cargo-install:

       --git url
           Git URL to install the specified crate from.

       --branch branch
           Branch to use when installing from git.

       --tag tag
           Tag to use when installing from git.

       --rev sha
           Specific commit to use when installing from git.

so we would have to at least support --branch/--tag/--rev just like cargo-install.

I think cargo-install finds the Cargo.toml by the package name, so we can also do that in cargo-binstall.

Originally posted by @NobodyXu in #1162 (comment)

@NobodyXu
Copy link
Member Author

I tried implementing it #1162 (comment) , but it's harder than I imagined.

So I decided to postpone it until upstream gix has support for this.

@NobodyXu NobodyXu added the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Jun 23, 2023
@passcod passcod mentioned this issue Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)
Projects
None yet
Development

No branches or pull requests

1 participant