Allows for single and double tap on each post #16
Conversation
Quite a lot of changes in order to achieve this: - had to activate the navigation link programmatically in order to capture single and double tap - NavigationLink activated based on new view state for selected post tag - moved the RequestView to the ContentView so the selected post wouldn't reload the whole PostList and retriever the request - PostList now initialised with Listing object - setting the contentShape of the PostView in the list in order to capture hits in the whole area, otherwise it would land on the NavigationLink behind - adding two tap gestures in order of precedence - set the default frame for the new spinner to guarantee a minimum size while loading The only secondary effect from this solution I wasn't able to fix is that now cells don't get a selected state like before. I accept suggestions.
banaslee
changed the title
|
Maybe for now fake the selection with a |
|
Got selection state but unfortunately is not blue like before with NavigationLink. |
…st id init parameters; Using a computed property for the list and navigation link selections; Listing now has a computed property to return an array of Posts.
Made the section non-collapsible
|
Couldn't get a blue selection after many tries but there's a strange bug:
I'm throwing the towel on this one :) |
|
This looks really good, but there is one issue 😂 (besides the one you mentioned, but I think it's related). If you click on the edge (outside the text or images), it gives a blue highlight but doesn't actually show the page. Could you push the clickable area all the way up to the edge so they can't select that? Hopefully Apple releases some fixes for this stuff in a few weeks with macOS 10.16 |
|
I’ll give it a try. But if these are the only issues I propose it’s merged and new issues get opened. Can become good issues for first contributors. |
|
Ok, I’ll merge now. Great work |
Fixes #9
Quite a lot of changes in order to achieve this:
The only secondary effect from this solution I wasn't able to fix is that now cells don't get a selected state like before. Hopefully someone knows how to fix that, otherwise can be a good bug to follow up with.