Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex match is incomplete or broken. #86

Open
roperto opened this issue Mar 20, 2018 · 1 comment
Open

Regex match is incomplete or broken. #86

roperto opened this issue Mar 20, 2018 · 1 comment

Comments

@roperto
Copy link
Contributor

roperto commented Mar 20, 2018

The characters \/-.?*+^$ are escaped before matching so they don't break an URL.

IMHO that defeats the purpose of having a regex or imposes a rigit limit on what regexes you can write.

My suggestion would be that anything that does not start with http or https is considered a regex WITH delimiters. Better yet, anything that does not start with a letter is a regex and we should not assume / as delimiter.

@brendanheywood
Copy link
Contributor

My 2cents, the idea of the regex was from the very earliest stages of the design of this. I think it should be moved to 100% wwwroot for each env and deprecate the regex concept completly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants