Skip to content

Commit 33c39c8

Browse files
committed
Update comment after discussion in data-apis#279
1 parent 42d454a commit 33c39c8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

spec/API_specification/examples/03_sklearn_like_pipeline.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ def fit(self, df: DataFrame) -> Self:
3333
scalings = scalings.collect()
3434

3535
self.scalings_ = {
36-
# Clarify: Should the return type of `get_value` (lazy /
37-
# eager scalar) depend on a previous call to `collect`?
36+
# Note: `get_value` returns an implemenation-defined,
37+
# duck-typed scalar which may be lazy.
3838
column_name: scalings.get_column_by_name(column_name).get_value(0)
3939
for column_name in self.column_names
4040
}

0 commit comments

Comments
 (0)