Skip to content

Commit c292174

Browse files
rix0rrrgithub-actions
and
github-actions
authored
fix: reduce dependency upgrade frequency to once a week (#827)
* fix: reduce dependency upgrade frequency to once a week Remove the options that falsely give you an idea that this behavior can be configured on a per-repository basis. It cannot. * chore: self mutation Signed-off-by: github-actions <[email protected]> --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
1 parent f264dbe commit c292174

8 files changed

+24
-87
lines changed

.github/workflows/upgrade-dev-deps-main.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/upgrade-main.yml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

API.md

-60
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projenrc/cdk-construct-library-options.ts

+4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ export function generateCdkConstructLibraryOptions(project: typescript.TypeScrip
2323
},
2424
},
2525
},
26+
omitProps: [
27+
// These properties are ignored; a CdkLabsConstructLibrary does what it wants anyway.
28+
'depsUpgrade', 'depsUpgradeOptions',
29+
],
2630
properties: [
2731
...COMMON_OPTIONS,
2832
{

src/cdk-construct-library-options.ts

-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/common-options.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,13 @@ export function configureCommonComponents(project: typescript.TypeScriptProject,
7979
new UpgradeCdklabsProjenProjectTypes(project);
8080
}
8181

82-
if ((opts.upgradeRuntimeDepsAsFix)) {
82+
if (opts.upgradeRuntimeDepsAsFix) {
8383
const exclude = opts.upgradeCdklabsProjenProjectTypes ? UpgradeCdklabsProjenProjectTypes.deps : [];
8484
const labels = opts.autoApproveUpgrades ? [opts.autoApproveOptions?.label ?? 'auto-approve'] : [];
8585

86+
// Run at 18:00Z once a week (on Monday)
87+
const upgradeSchedule = javascript.UpgradeDependenciesSchedule.expressions(['0 18 * * 1']);
88+
8689
new javascript.UpgradeDependencies(project, {
8790
taskName: 'upgrade',
8891
// NOTE: we explicitly do NOT upgrade PEER dependencies. We want the widest range of compatibility possible,
@@ -94,7 +97,7 @@ export function configureCommonComponents(project: typescript.TypeScriptProject,
9497
semanticCommit: 'fix',
9598
workflowOptions: {
9699
labels,
97-
schedule: javascript.UpgradeDependenciesSchedule.expressions(['0 18 * * *']),
100+
schedule: upgradeSchedule,
98101
},
99102
});
100103

@@ -106,6 +109,7 @@ export function configureCommonComponents(project: typescript.TypeScriptProject,
106109
pullRequestTitle: 'upgrade dev dependencies',
107110
workflowOptions: {
108111
labels,
112+
schedule: upgradeSchedule,
109113
},
110114
});
111115
}

test/__snapshots__/cdk.test.ts.snap

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/__snapshots__/cdklabs.test.ts.snap

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)