Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame pointer: use blob API commitment instead of block height and tx index #127

Closed
tuxcanfly opened this issue May 29, 2023 · 2 comments
Closed

frame pointer: use blob API commitment instead of block height and tx index #127

tuxcanfly opened this issue May 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tuxcanfly
Copy link
Collaborator

tuxcanfly commented May 29, 2023 •
edited
Loading

Currently the tx index is hardcoded to 0, as the submit_pfb endpoint does not return an index for the data we just submitted.

We should use a commitment to the data we just posted, either a coordinate in the EDS or a transaction hash so that the query is actually unique.
@tuxcanfly tuxcanfly added the enhancement New feature or request label May 29, 2023
@tuxcanfly tuxcanfly changed the title frame pointer: use transaction commitment instead of block height + tx index frame pointer: use data coorindates instead of block height and tx index Jun 5, 2023
@tuxcanfly tuxcanfly changed the title frame pointer: use data coorindates instead of block height and tx index frame pointer: use blob API commitment instead of block height and tx index Jun 6, 2023
@tuxcanfly
Copy link
Collaborator Author

See: https://node-rpc-docs.celestia.org/#blob

@tuxcanfly
Copy link
Collaborator Author

Closing as fixed in v0.2.0-OP_v1.2.0-CN_v0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tuxcanfly