fix eslint rules not actually linting (specifically floating promises)

[nicolasbrugneaux]

Fix the eslint not linting properly and leading to flaky codebase and tests