Merge pull request #305 from erikgb/fix-dynamic-cert-runnable

fix: dynamic cert runnable must NOT be leader election aware

Author: jetstack-bot

pkg/internal/cmd/cmd.go

@@ -100,9 +100,7 @@ func NewCommand(ctx context.Context) *cobra.Command {
 				return fmt.Errorf("unable to create controller manager: %w", err)
 			}
 
-			if err := mgr.Add(manager.RunnableFunc(func(ctx context.Context) error {
-				return certificateSource.Run(ctx)
-			})); err != nil {
+			if err := mgr.Add(&dynamicCertRunnable{source: certificateSource}); err != nil {
 				return err
 			}
 
@@ -143,3 +141,19 @@ func NewCommand(ctx context.Context) *cobra.Command {
 
 	return cmd
 }
+
+type dynamicCertRunnable struct {
+	source *servertls.DynamicSource
+}
+
+func (c *dynamicCertRunnable) Start(ctx context.Context) error {
+	return c.source.Run(ctx)
+}
+
+func (c *dynamicCertRunnable) NeedLeaderElection() bool {
+	// By default, a runnable in c/r is leader election aware.
+	// Since we need certs for all replicas, this runnable must NOT be leader election aware.
+	return false
+}
+
+var _ manager.LeaderElectionRunnable = &dynamicCertRunnable{}