Hardcoded paths in multiple files

[kunalsz]

Upon going through multiple files in the codebase I found out that in many files the filepaths's are being hardcoded which breaks if BuffaLogs runs in a different directory.

for example in buffalogs/impossible_travel/views.py

DATA_PATH = "impossible_travel/dashboard/"
with open(os.path.join(DATA_PATH, name + ".json")) as file:

This can simply be updated by using

DATA_PATH = os.path.join(settings.BASE_DIR, "impossible_travel/dashboard/")

Before making a PR I would like to know your views. @ManofWax @Lorygold

[Lorygold]

Hi @kunalsz, the observation is valid, but the correct settings path to use should be settings.CERTEGO_DJANGO_PROJ_BASE_DIR, instead of settings.BASE_DIR, isn't it?

[kunalsz]

@Lorygold what I can understand is that BASE_DIR = Path(__file__).resolve().parent.parent goes 2 levels up , whereas CERTEGO_DJANGO_PROJ_BASE_DIR = Path(__file__).resolve().parent.parent.parent goes 3 levels up. To ensure the path works regardless of where Django is executed,shouldn't we use BASE_DIR ?