Code Refactoring : Duplication of logic

[kunalsz]

Issue

In tasks.py , duplication of logic/code happens which can be done by using a simple function

@shared_task(name="BuffalogsCleanModelsPeriodicallyTask")
def clean_models_periodically():
    """Delete old data in the models"""
    app_config = Config.objects.get(id=1)
    now = timezone.now()
    delete_user_time = now - timedelta(days=app_config.user_max_days)
    User.objects.filter(updated__lte=delete_user_time).delete()

    delete_login_time = now - timedelta(days=app_config.login_max_days)
    Login.objects.filter(updated__lte=delete_login_time).delete()

    delete_alert_time = now - timedelta(days=app_config.alert_max_days)
    Alert.objects.filter(updated__lte=delete_alert_time).delete()

    delete_ip_time = now - timedelta(days=app_config.ip_max_days)
    UsersIP.objects.filter(updated__lte=delete_ip_time).delete()

Solution

A new function can be made which takes in the Model and the days as args and deletes the old data

def delete_old_data(model, days):
    now = timezone.now()
    delete_time = now - timedelta(days=days)
    model.objects.filter(updated__lte=delete_time).delete()

This refines the code and make things more readable.

@Lorygold @ManofWax looking forward to your insights !

[ManofWax]

Hi, yes your are right you can go on and make a PR

[Lorygold]

Discussion closed because the related issue has been opened: #224