CH573 default configuration issue

[sleepwalkera]

Description:
When testing with wchisp v0.3.0 on CH573F-EVT-R0 development board, I encountered a verification error with the default reset configuration.

Steps to reproduce:

1. Use devices/0x13-CH57x.yaml with default reset: 0x4FFF0F55
2. Attempt to flash the CH573F-EVT-R0 board
3. Get error: "Error: Verify failed, mismatch"

Expected behavior:
Successful flashing with default reset configuration

Actual behavior:
Verification fails with default reset value

Workaround:
Changing to reset: 0x4FFF0F4D allows successful flashing

Environment:

• Tool: wchisp v0.3.0
• Board: CH573F-EVT-R0
• Configuration file: devices/0x13-CH57x.yaml

Additional context:
This might indicate either:

1. The default reset value needs updating for CH573F
2. Different CH57x variants may require different reset values

[DeqingSun]

The original code worked fine on my CH571

04:14:52 [INFO] Chip: CH571[0x7113] (Code Flash: 192KiB, Data EEPROM: 32KiB)
04:14:52 [INFO] Chip UID: 1C-7B-AE-10-53-5C-1D-E8
04:14:52 [INFO] BTVER(bootloader ver): 02.90

[biemster]

042b7c2 is the likely culprit here i guess.

[DeqingSun]

@sleepwalkera
I need to make some addition to my comment.
I think the reason my board worked was that, I only used flash feature and I did not touch the configuration.
Actually Setting CFG_DEBUG_EN bit (bit 4) may cause the ISP not to work. I did some test in #34 (comment)
The A5 flash command will return fe 00 when CFG_DEBUG_EN is set, while it returns 00 00 when CFG_DEBUG_EN is cleared. And the Verify failure will happen at the first code block. I think the flash won't be successful when CFG_DEBUG_EN is enabled.

[biemster]

I think the flash won't be successful when CFG_DEBUG_EN is enabled.

I agree with this, I see the same behaviour on ch58x and ch59x. If debug is enabled, those chips can only be flashed over the debug interface and not via ISP anymore.

[ayuusweetfish]

won't be successful when CFG_DEBUG_EN is enabled

+1. I have discovered the same phenomenon on a CH571 (only CFG_DEBUG_EN matters; other bits do not matter). When CFG_DEBUG_EN is 1, flash-write commands (a5) are responded with a5 00 02 00 fe 00, rather than …00 00. (My reference: https://github.com/frank-zago/isp55e0/blob/51a33e1/protocol.txt#L118)

Unfortunately, as of now there does not seem to be a convenient way to flip this switch, since the config set command is unimplemented. My current workaround is to edit devices/0x13-CH57x.yaml and change the reset value to 0x4FFF0F45 (from …55), and build from source.

Could the program issue an error (and probably a hint to resolution) in this case? Also, how was config set supposed to work? I'd be glad to help implement something ^ ^

[biemster]

Also, how was config set supposed to work? I'd be glad to help implement something ^ ^

Something like this: https://github.com/biemster/ch573_minimal/blob/89289484c129127f97a1c473c567a8c5b9bbb900/ch573_config.py#L73

[ayuusweetfish]

@biemster Thanks for the reference! I noticed that my expression was ambiguous: I meant that I was curious how the interface was originally designed, i.e. should the user specify the names of the flags to assign/toggle like README's config set SRAM_CODE_MODE=1, or do they simply supply a sequence of hex-encoded values, etc.? (I suppose that might belong to a new discussion thread, though. Apologies for the misunderstanding ^ ^)

[DeqingSun]

@biemster Thanks for the reference! I noticed that my expression was ambiguous: I meant that I was curious how the interface was originally designed, i.e. should the user specify the names of the flags to assign/toggle like README's config set SRAM_CODE_MODE=1, or do they simply supply a sequence of hex-encoded values, etc.? (I suppose that might belong to a new discussion thread, though. Apologies for the misunderstanding ^ ^)

You provide a hex value. But you still need to recompile the binary as the flashing.write_config is commented out.

wchisp/src/main.rs

Lines 327 to 331 in f18828c

	Some(ConfigCommands::Set { value }) => {
	// flashing.write_config(value)?;
	log::info!("setting cfg value {}", value);
	unimplemented!()
	}