Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a glossary of common terms #52

Closed
wants to merge 2 commits into from

Conversation

adam2k
Copy link
Contributor

@adam2k adam2k commented Oct 27, 2022

Resolves #50

Add a glossary of common terms after the appendix.

@willcl-ark
Copy link
Collaborator

willcl-ark commented Oct 28, 2022

Hey Adam, this looks like a great start to this section!

I added a second commit with some minor fixups which I noticed on a first read. Perhaps you could check if you are happy with them?

I pushed a version with these two commits to https://obc.256k1.dev/#_glossary already, so you can see what it looks like live (which you can also do locally by running asciidoctor -r asciidoctor-diagram --verbose --trace index.adoc; open index.html FYI).

Edit: I know the diff looks large, but really most of it was just newlines (one sentence per line).

@willcl-ark
Copy link
Collaborator

Just fixed (my own) tab indentations :)

@adam2k
Copy link
Contributor Author

adam2k commented Oct 30, 2022

@willcl-ark the changes look good! I was able to see them in the git diff, but I didn't see them on the website. Maybe something is still cached for me or you reverted those changes? I tried in two different browsers and I couldn't see the glossary.

@willcl-ark
Copy link
Collaborator

Try refreshing the browser cache (ctrl + shift + r or perhaps cmd+shift+r?)

@willcl-ark
Copy link
Collaborator

Merged in e9538fc

@willcl-ark willcl-ark closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary of Terms and Tooltip on abbreviations
2 participants