Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad scoring: gum filter fuzzy sort #701

Open
Simon-He95 opened this issue Nov 5, 2024 · 3 comments
Open

bad scoring: gum filter fuzzy sort #701

Simon-He95 opened this issue Nov 5, 2024 · 3 comments
Labels
bug Something isn't working cmd/filter

Comments

@Simon-He95
Copy link

image
@caarlos0 caarlos0 added cmd/filter bug Something isn't working labels Nov 18, 2024
@caarlos0
Copy link
Member

caarlos0 commented Dec 3, 2024

i tried this with fzy and fzf, and both give similar results.

I think fzy and fzf are a bit better if you start the search with v, e.g. v14.

The one we use works differently though.

Will defer to the team on whether we try to port fzy, or something else... :)

@meowgorithm meowgorithm changed the title gum filter fuzzy sort bad scoring: gum filter fuzzy sort Dec 3, 2024
@meowgorithm
Copy link
Member

Just to add some more context, here's how fzy handles it. In this case, it appears that precedence is being given . as a word separator.

fzy example

Regardless, I agree that the matching algorithm can indeed be improved.

@Simon-He95
Copy link
Author

after fzy handle ,maybe twice sort according to fzy match rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmd/filter
Projects
None yet
Development

No branches or pull requests

3 participants