Add tests to your code

[ccoVeille]

Is your feature request related to a problem? Please describe.

I feel annoyed by the fact the code is barely tested.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Add tests, please.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Hope nothing will get broken on each commits and trust maintainers 😅

Additional context
Add any other context or screenshots about the feature request here.

[caarlos0]

we're definitely suffering from this!

this is also an easy way to contribute, if anyone is interested :)

[ccoVeille]

I would say you should start a bit to do it.
This way tests will be your ways.

Because from here our discussion might sound like 🤣

Parent (me): Hey Carlos, could you please clean your room ?
You: Yes, I know ... but don't you want to help me ?"

Joke aside, I would like you to start testing the code you add, otherwise the flow will never stop.

[caarlos0]

fair enough! 😆

[caarlos0]

gonna brain dump some stuff here, more as a means of noting them to future me than anything else :P

1. commands will need a way to set stdout/stderr/stdin for we to be able to test them
2. incidentally, commands will need to adjust usage (e.g. use fmt.Fprint instead of fmt.Print)
3. might need some restructuring to allow us to use teatest (this will be easier with the v2 stack)
4. we might benefit from start listing expected behaviors from each sub command before doing the above

[ccoVeille]

https://github.com/rogpeppe/go-internal?tab=readme-ov-file#testscript

This might help

[caarlos0]

yes, good call!
we already use it in soft-serve and a couple others (I think)

[m-rit]

hey @caarlos0
I am interested in contributing to this issue . If this isn't assigned to anyone, is it okay if I pick this up ?