Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for GetHorizontalFrameSize #353

Open
bashbunni opened this issue Aug 22, 2024 · 1 comment
Open

add tests for GetHorizontalFrameSize #353

bashbunni opened this issue Aug 22, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@bashbunni
Copy link
Member

bashbunni commented Aug 22, 2024

I don't think GetHorizontalFrameSize is working properly. I just ran an example that had a border and padding, but it only returned the amount of padding and didn't include the border

This is the program I ran https://github.com/charmbracelet/bubbletea/blob/master/examples/glamour/main.go

When I set glamour's word wrapping to vp.Width-4 it works fine, but if I use vp.Style.GetHorizontalFrameSize() it only returns 2, so breaks the table.

@bashbunni bashbunni added bug Something isn't working help wanted Extra attention is needed labels Aug 22, 2024
@bashbunni
Copy link
Member Author

related: #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant