Skip to content

v2 pre-launch checklist #484

@bashbunni

Description

@bashbunni

Things to tidy up before launch

  • remove custom renderers from docs v2: remove custom renderer functions #507
  • review bug reports in Lip Gloss to determine what might be fixed in v2, then add to the v2.0.0 milestone
  • make sure new API additions have godoc + tests
  • I recall someone mentioning that our ordering for some functions don't match e.g. with two arguments a function treats that as vertical, horizontal but others do horizontal, vertical
  • remove LegacyANSIWindows and ansi_unix.go?

Considerations:

  • Exposing number of rows displayed (since Lip Gloss does all the visible row calculations)? While working on bubbles table, it's hard to customize navigation based on # of rows visible e.g. when doing PageUp/Down it's supposed to be the next set of visible rows and relies on knowing the number of visible rows. You can't use lipgloss.Height for this as there may or may not be headers for the table + borders between rows may or may not exist

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions