[18.0][MIG] sale_stock_mto_as_mts_orderpoint: Migration to 18.0 #2
Conversation
For user without proper rights the confirmation of a sale.order can lead to an access error on the orderpoint creation. The sudo fixes that.
On sale confirmation generate the procurement if the rule is on the sale order line OR the rule is activated on the product.
When generation the orderpoint from the sale order line, it might happen that the sale_order_line's product is a BOM, the moves that are generated are based on the components that composes it. For this reason, when creating the purchase order, we have to get the product from moves, not sale order lines.
Add a flag `mto_as_mts`on the warehouse to activate the functionality of the module. It will fix the interferences with other modules in the repository. And allows for better customization This a backport from v16 improvements.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-14.0/stock-logistics-workflow-14.0-sale_stock_mto_as_mts_orderpoint Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-14-0/stock-logistics-workflow-14-0-sale_stock_mto_as_mts_orderpoint/
chaule97
force-pushed
the
18.0-mig-sale_stock_mto_as_mts_orderpoint
branch
from
7198047 to
639c819
Compare
xaviedoanhduy
left a comment
xaviedoanhduy
left a comment
There was a problem hiding this comment.
I see you changed quite a bit about accessing from product.route_ids to product_tmpl_id.route_ids. but what is the purpose of this change because the product.product model also has a route_ids field?
| ) | ||
| ) | ||
|
|
||
| self.env["procurement.group"].run(procurements) |
There was a problem hiding this comment.
Is there a need to check for existence of procurements? https://github.com/odoo/odoo/blob/202d7ac2297185d4384638726afacc2bbe160d40/addons/sale_stock/models/sale_order_line.py#L386-L387
| if ( | ||
| not delivery_move.is_from_mto_route | ||
| or line.product_id._variant_is_not_mto() | ||
| and mto_route |
There was a problem hiding this comment.
won't the above code return early when mto_route doesn't exist?
if not mto_route:
return
There was a problem hiding this comment.
it's and mto_route not in delivery_move.product_id.route_ids, because code line is too long
There was a problem hiding this comment.
can you add description of this file appearance? is it split from stock_orderpoint_manual_procurement?
There was a problem hiding this comment.
yes, I get these code from stock_orderpoint_manual_procurement
chaule97
force-pushed
the
18.0-mig-sale_stock_mto_as_mts_orderpoint
branch
from
639c819 to
b3a8811
Compare
chaule97
force-pushed
the
18.0-mig-sale_stock_mto_as_mts_orderpoint
branch
from
b3a8811 to
4e56965
Compare
stock_orderpoint_manual_procurementis deprecated, so I remove it in depends and write more code aboutstock_warehouse_orderpoint