Skip to content

Commit 1418114

Browse files
authored
fix: the test command's --tags option now also matches CheckGroups [sc-23699] (#1047)
* fix: the test command's --tags option now includes matching CheckGroups This is the intended behavior, but an oversight in the code effectively disabled it. * fix: don't modify Check's tags directly, create a new array instead
1 parent 04de119 commit 1418114

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: packages/cli/src/commands/test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -199,11 +199,11 @@ export default class Test extends AuthCommand {
199199
return filterByCheckNamePattern(grep, check.name)
200200
})
201201
.filter(([, check]) => {
202-
const tags = check.tags ?? []
202+
const tags = [...check.tags ?? []]
203203
const checkGroup = this.getCheckGroup(project, check)
204204
if (checkGroup) {
205205
const checkGroupTags = checkGroup.tags ?? []
206-
tags.concat(checkGroupTags)
206+
tags.push(...checkGroupTags)
207207
}
208208
return filterByTags(targetTags?.map((tags: string) => tags.split(',')) ?? [], tags)
209209
})

0 commit comments

Comments
 (0)