-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some config results in OOM, reduce list of project in config #141
Comments
@romani How to investigate? |
Just remove projects from list until it pass :). We generate too much violations, it blows up to generate website. |
in referenced PR, they will split config in few, they will probably put jdk in separate config. |
…f project in config
…f project in config
…f project in config
regexp still has problems checkstyle/checkstyle#15578 (comment)
Problem is in our config, checkstyle classes failing to load it. At checkstyle/checkstyle#13345 I see that it is not Enabled, so it means that configs might be broken. It will be good to find mistake and fix Examples in checkstyle repository. Problem is at:
Value has Problem should be fixed in checkstyle repository. |
|
For IllegalTokenText and MultipleStringLiterals, we made changes for the configs to be correct in the extractor. Earlier, we noticed there was a difference wrt how configs from main repo of checkstyle and the generated ones had wrt quotes. We saw double quotes being wrapped under value. We made code changes to make it single quotes complying with the examples files in main repo in this PR: #212 |
https://github.com/checkstyle-gsoc/checkstyle/actions/runs/11305582825/job/31445261771 Github, generate report for InterfaceMemberImpliedModifier/all-examples-in-one The results were successful. Doing a second round of testing in main repo. Runner: https://github.com/checkstyle/checkstyle/actions/runs/11305872027 UPDATE: |
https://github.com/checkstyle-gsoc/checkstyle/actions/runs/11305891527 Github, generate report for NeedBraces/all-examples-in-one The results were successful. Doing a second round of testing in main repo. Runner: https://github.com/checkstyle/checkstyle/actions/runs/11306157786 UPDATE: |
For TrailingComment, Despite deleting the project list of openjdk21, checkstyle-sonar my the execution is stuck. Possibly, example3 and 4 are causing issues.
|
For regex, we had to create a PR to make sure generated configs are i sync with actual xml configs in example files. Test run: https://github.com/checkstyle/checkstyle/actions/runs/11310865938 |
While testing regression testing of WhitespaceAround Check, we realised it led to OOM issue. We need to see which projects can be removed to keep it light weight.
Full list at #120 (comment)
The text was updated successfully, but these errors were encountered: