Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version downgrading broke some builds #4

Open
folex opened this issue Dec 4, 2020 · 2 comments
Open

Version downgrading broke some builds #4

folex opened this issue Dec 4, 2020 · 2 comments

Comments

@folex
Copy link

folex commented Dec 4, 2020

Hi! Thanks a lot for your hard work and contribution to the Elm ecosystem.

Renaming the version from 1.1.1 to 1.0.1 seems to broke some of my builds. It is possible that I'm not the only one. Could you please consider keeping 1.1.1 and keep the Elm ecosystem a little bit more stable?

Thanks in advance!

@chelovek0v
Copy link
Owner

chelovek0v commented Dec 4, 2020

Hi! I didn't rename the version, but I did rename my GH account and this broke things; I'm sorry and I didn't want this to happen. I sent emails to people who depend on my package advising them to update and notice the change.

Due to some limitations in Elm and GH I can't update or support the previous package(with the previous name and the version).

Your builds of course didn't break just because the version is changed, but because hashes of releases changed since I changed my account name. So the package is corrupted and elm spits errors at you. Fixing just a version won't do anything – you should update your dependencies with the new one.

"chelovek0v/bbase64": "1.0.1 <= v < 2.0.0" in your elm.json

Also you can read about a similar problem and how to protect from it https://discourse.elm-lang.org/t/skinney-murmur3-not-downloading/6285/3

@folex
Copy link
Author

folex commented Dec 4, 2020

To me, it seemed like redirects worked fine, i.e., from the previous repo name to the current one, but then it failed because it got 404. Maybe if it weren't to 404, it would fail later due to hashing, as you say.

The log was like this

-- PROBLEM DOWNLOADING PACKAGE -------------------------------------------------

I was trying to download the source code for ivadzy/bbase64 1.1.1, so I tried to
fetch:

    https://github.com/ivadzy/bbase64/zipball/1.1.1/

But it came back as 404 Not Found.

It was easy to fix, however.

Thanks for your quick and kind reply!

Viir added a commit to Viir/bots that referenced this issue Jan 18, 2021
See the discussion of Elm package names at chelovek0v/bbase64#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants