New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove this property #54

Open

lpatiny opened this issue Sep 8, 2021 · 1 comment

Member

lpatiny commented Sep 8, 2021 •

edited

Loading

cheminfo-types/src/spectra/core/MeasurementResult.ts

Lines 12 to 14 in d203027

    
           derivedProperties?: Record<string, BaseDerivedProperty>; //  TodDo: properly define derived propery, e.g., should always have a technique 
        
           /**Comments on the measurement */ 
        
           remarks?: HTMLString;

I would not allow free addition of properties like that. Each analysis should have their own well specified derived data and corresponding field name

Member Author

lpatiny commented Sep 8, 2021

@kjappelbaum What do you think ?

targos mentioned this issue

Remove this property #53

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment