Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head-min and self-contained #16

Open
stropitek opened this issue Jun 15, 2016 · 2 comments
Open

head-min and self-contained #16

stropitek opened this issue Jun 15, 2016 · 2 comments

Comments

@stropitek
Copy link
Contributor

As of today, when a view has an unknown version it falls back to head-min (I did this because if so it is very likely that the view has be saved on head)

This causes problems in self-contained mode because all versions of visualizer are downloaded just once. Thus the head-min will never be up-to-date.

Two possible solutions:

  • Fallback to latest, and views saved on head might not work on built website. For consistency the behavior would be the same when not using self-contained mode.
  • Keep fallback to head-min, and download head-min on every build

I'd rather go for the 1st solution. Production views should probably not be on head anyway, and solution 2 is overkill.

@targos, @lpatiny what do you think?

@lpatiny
Copy link
Member

lpatiny commented Jun 15, 2016

Well we know that it is risky to save on head because on the long term it will anyway fail. Should we simply allow this ? If we want to reload the page we should maybe just copy / paste the view but the view is always saved on a real version.

@targos
Copy link
Member

targos commented Jun 15, 2016

I think it should fallback to closest release version.
Example: current version is 2.1.0 and view is saved on HEAD (2.1.0-0) => use 2.1.0. Next time a release is done, use this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants