Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize URL naming #350

Open
GDay opened this issue Sep 10, 2023 · 0 comments
Open

Standardize URL naming #350

GDay opened this issue Sep 10, 2023 · 0 comments

Comments

@GDay
Copy link
Member

GDay commented Sep 10, 2023

Currently, we have a combination of hyphens and underscores in the names of the urls. For example here:

path(
"password/reset_request/",
PasswordResetView.as_view(
template_name="password_reset.html",
email_template_name="email/reset.html",
subject_template_name="email/reset_subject.txt",
),
name="password-reset",
),
path(
"password/reset_request/done/",
PasswordResetDoneView.as_view(
template_name="password_reset_done.html",
),
name="password_reset_done",

It would be good to make this more standardized to one of the two. I think Django goes with hyphens: https://docs.djangoproject.com/en/4.2/topics/http/urls/#examples by default.

Mentioned here: #346 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant