Skip to content

Commit cbbd154

Browse files
authored
Merge pull request #24 from chime/igna/1debit_to_chime
Move from @1debit to @chime
2 parents 1095de7 + 15fa090 commit cbbd154

File tree

17 files changed

+31
-31
lines changed

17 files changed

+31
-31
lines changed

CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @1debit/infrastructure-eng
1+
* @chime/maintainers

README.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# mani-diffy
22

3-
![Tests](https://github.com/1debit/mani-diffy/actions/workflows/tests.yaml/badge.svg)
3+
![Tests](https://github.com/chime/mani-diffy/actions/workflows/tests.yaml/badge.svg)
44

5-
This program walks a hierarchy of Argo CD Application templates, renders Kubernetes manifests from the input templates, and posts the rendered files back for the user to review and validate.
5+
This program walks a hierarchy of Argo CD Application templates, renders Kubernetes manifests from the input templates, and posts the rendered files back for the user to review and validate.
66

7-
It is designed to be called from a CI job within a pull request, enabling the author to update templates and see the resulting manifests directly within the pull request before the changes are applied to the Kubernetes cluster.
7+
It is designed to be called from a CI job within a pull request, enabling the author to update templates and see the resulting manifests directly within the pull request before the changes are applied to the Kubernetes cluster.
88

99
The rendered manifests are kept within the repository, making diffs between revisions easy to parse, dramatically improving safety when updating complex application templates.
1010

@@ -19,8 +19,8 @@ The rendered manifests are kept within the repository, making diffs between revi
1919

2020
🫵 Submit a PR where you make a change to the overrides of the [`demo`](demo/README.md), and you'll see the [Github action]( [README](../../.github/workflows/generate-manifests-demos.yaml)) add a commit to your PR with the resulting changes.
2121

22-
<img width="1099" alt="1" src="https://github.com/1debit/mani-diffy/assets/9005904/6b6d9e45-57f7-43ff-906f-ebf4c0a03ad9">
23-
<img width="1701" alt="2" src="https://github.com/1debit/mani-diffy/assets/9005904/03d4a49e-1fc9-40a1-9882-1c032b2d345b">
22+
<img width="1099" alt="1" src="https://github.com/chime/mani-diffy/assets/9005904/6b6d9e45-57f7-43ff-906f-ebf4c0a03ad9">
23+
<img width="1701" alt="2" src="https://github.com/chime/mani-diffy/assets/9005904/03d4a49e-1fc9-40a1-9882-1c032b2d345b">
2424

2525
# See it in action in a video !
2626

@@ -29,7 +29,7 @@ In this screen recording a pull request is opened to make the following changes
2929
1. Bump the count of pods for the `foo` service in the prod cluster
3030
2. Add an annotation to all services
3131

32-
https://github.com/1debit/mani-diffy/assets/9005904/6c496996-f7af-4932-bf5d-01a5b57bbd99
32+
https://github.com/chime/mani-diffy/assets/9005904/6c496996-f7af-4932-bf5d-01a5b57bbd99
3333

3434

3535
## Post Renderers
@@ -44,7 +44,7 @@ The command will be called with the output directory as the first argument (e.g.
4444

4545
---
4646

47-
## Pre-requisites
47+
## Pre-requisites
4848

4949
This is for a new user that is looking to use mani-diffy on a new repo.
5050

@@ -55,7 +55,7 @@ In order to make use of mani-diffy on the repo that holds all of your ArgoCD app
5555

5656
`mani-diffy` itself makes no assumptions about how the repo is structured, as long as it can successfully render the charts it encounters while walking the Application tree.
5757

58-
However, you may find it useful to organize your repo similarly to the demo app, with 3 key directories :
58+
However, you may find it useful to organize your repo similarly to the demo app, with 3 key directories :
5959

6060
1. a "root" or "bootstrap" directory that holds all the ArgoCD applications manifests.
6161
2. a "charts" directory that contains all the helm charts needed for the ArgoCD applications.

demo/.zz.auto-generated/prod-app-group-1/manifest.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
server: https://kubernetes.default.svc
1111
project: default
1212
source:
13-
repoURL: https://github.com/1debit/mani-diffy.git
13+
repoURL: https://github.com/chime/mani-diffy.git
1414
path: charts/service
1515
helm:
1616
version: v3
@@ -34,7 +34,7 @@ spec:
3434
server: https://kubernetes.default.svc
3535
project: default
3636
source:
37-
repoURL: https://github.com/1debit/mani-diffy.git
37+
repoURL: https://github.com/chime/mani-diffy.git
3838
path: charts/service
3939
helm:
4040
version: v3

demo/.zz.auto-generated/prod-cluster/manifest.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
server: https://kubernetes.default.svc
1111
project: default
1212
source:
13-
repoURL: https://github.com/1debit/mani-diffy.git
13+
repoURL: https://github.com/chime/mani-diffy.git
1414
targetRevision: HEAD
1515

1616
path: charts/app-of-apps

demo/.zz.auto-generated/test-app-group-1/manifest.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
server: https://kubernetes.default.svc
1111
project: default
1212
source:
13-
repoURL: https://github.com/1debit/mani-diffy.git
13+
repoURL: https://github.com/chime/mani-diffy.git
1414
path: charts/service
1515
helm:
1616
version: v3
@@ -34,7 +34,7 @@ spec:
3434
server: https://kubernetes.default.svc
3535
project: default
3636
source:
37-
repoURL: https://github.com/1debit/mani-diffy.git
37+
repoURL: https://github.com/chime/mani-diffy.git
3838
path: charts/service
3939
helm:
4040
version: v3
@@ -58,7 +58,7 @@ spec:
5858
server: https://kubernetes.default.svc
5959
project: default
6060
source:
61-
repoURL: https://github.com/1debit/mani-diffy.git
61+
repoURL: https://github.com/chime/mani-diffy.git
6262
path: charts/service
6363
helm:
6464
version: v3

demo/.zz.auto-generated/test-cluster/manifest.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
server: https://kubernetes.default.svc
1111
project: default
1212
source:
13-
repoURL: https://github.com/1debit/mani-diffy.git
13+
repoURL: https://github.com/chime/mani-diffy.git
1414
targetRevision: HEAD
1515

1616
path: charts/app-of-apps

demo/bootstrap/prod-cluster.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ spec:
1818
valueFiles:
1919
- ../../overrides/bootstrap/prod-cluster.yaml
2020
path: charts/app-of-apps
21-
repoURL: https://github.com/1debit/mani-diffy.git
21+
repoURL: https://github.com/chime/mani-diffy.git
2222
targetRevision: HEAD
2323
syncPolicy:
2424
syncOptions:

demo/bootstrap/test-cluster.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ spec:
1818
valueFiles:
1919
- ../../overrides/bootstrap/test-cluster.yaml
2020
path: charts/app-of-apps
21-
repoURL: https://github.com/1debit/mani-diffy.git
21+
repoURL: https://github.com/chime/mani-diffy.git
2222
targetRevision: HEAD
2323
syncPolicy:
2424
syncOptions:

demo/charts/app-of-apps/templates/app-of-apps.tpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ spec:
1010
server: https://kubernetes.default.svc
1111
project: default
1212
source:
13-
repoURL: https://github.com/1debit/mani-diffy.git
13+
repoURL: https://github.com/chime/mani-diffy.git
1414
targetRevision: HEAD
1515

1616
path: charts/app-of-apps

demo/charts/app-of-apps/templates/service.tpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
server: https://kubernetes.default.svc
1212
project: default
1313
source:
14-
repoURL: https://github.com/1debit/mani-diffy.git
14+
repoURL: https://github.com/chime/mani-diffy.git
1515
path: charts/service
1616
helm:
1717
version: v3

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module github.com/1debit/mani-diffy
1+
module github.com/chime/mani-diffy
22

33
go 1.20
44

main.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import (
1212
"strings"
1313
"time"
1414

15-
"github.com/1debit/mani-diffy/pkg/helm"
16-
"github.com/1debit/mani-diffy/pkg/kustomize"
15+
"github.com/chime/mani-diffy/pkg/helm"
16+
"github.com/chime/mani-diffy/pkg/kustomize"
1717

1818
"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
1919
)

pkg/helm/helm.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import (
1717
"strings"
1818
"sync"
1919

20-
"github.com/1debit/mani-diffy/pkg/kustomize"
2120
"github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
21+
"github.com/chime/mani-diffy/pkg/kustomize"
2222
yamlutil "k8s.io/apimachinery/pkg/util/yaml"
2323
)
2424

pkg/helm/helm_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ func TestGenerateHashOnCrd(t *testing.T) {
224224
crd := data[0]
225225

226226
hash, err := generateHashOnCrd(crd)
227-
if err != nil || hash != "fba38c4479874778a2e0bf38c2e94f83d57d9f24c9c7d71e123bc5c1961ed936" {
228-
t.Error("Failed to generate correctly")
227+
if err != nil || hash != "7bfd65e963e76680dc5160b6a55c04c3d9780c84aee1413ae710e4b5279cfe14" {
228+
t.Errorf("Failed to generate correctly, got %s", hash)
229229
}
230230
}
231231

@@ -300,7 +300,7 @@ func TestDifferenceInTwoDifferentFiles(t *testing.T) {
300300
func TestGenerateHashOnChart(t *testing.T) {
301301
hash, _ := generalHashFunction("demo/charts/app-of-apps")
302302
h := hex.EncodeToString(hash)
303-
actualHash := "95630c1ec9b835536a3056d4dcbbd6e023111c5e4340ac80b945c2e3a4f8fc42"
303+
actualHash := "13aa148adefa3d633e5ce95584d3c95297a4417977837040cd67f0afbca17b5a"
304304
if h != actualHash {
305305
t.Errorf("Failed to generate a generic hash on a chart. got: %s wanted: %s", h, actualHash)
306306
}

pkg/helm/test_files/crdData_multiple_crd_testfile.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ spec:
1919
valueFiles:
2020
- ../../overrides/bootstrap/prod-cluster.yaml
2121
path: charts/app-of-apps
22-
repoURL: https://github.com/1debit/mani-diffy
22+
repoURL: https://github.com/chime/mani-diffy
2323
targetRevision: HEAD
2424
syncPolicy:
2525
syncOptions:
@@ -45,7 +45,7 @@ spec:
4545
valueFiles:
4646
- ../../overrides/bootstrap/test-cluster.yaml
4747
path: charts/app-of-apps
48-
repoURL: https://github.com/1debit/mani-diffy
48+
repoURL: https://github.com/chime/mani-diffy
4949
targetRevision: HEAD
5050
syncPolicy:
5151
syncOptions:

pkg/helm/test_files/crdData_testfile.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ spec:
1616
valueFiles:
1717
- ../../overrides/bootstrap/prod-cluster.yaml
1818
path: demo/charts/app-of-apps
19-
repoURL: https://github.com/1debit/mani-diffy
19+
repoURL: https://github.com/chime/mani-diffy
2020
targetRevision: HEAD
2121
syncPolicy:
2222
syncOptions:

pkg/helm/test_files/crdData_testfile_2.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ spec:
1919
- ../../overrides/bootstrap/prod-cluster.yaml
2020
- ../../overrides/bootstrap/fake_file.yaml
2121
path: charts/app-of-apps
22-
repoURL: https://github.com/1debit/mani-diffy
22+
repoURL: https://github.com/chime/mani-diffy
2323
targetRevision: HEAD
2424
syncPolicy:
2525
syncOptions:

0 commit comments

Comments
 (0)